Merge pull request #106 from rcmcdonald91/rcm-c-incref

oschwald · web-flow · commit d8accfeb5b21 · 2023-01-09T12:20:21.000-08:00
Add missing Py_INCREF in module initialization
diff --git a/extension/maxminddb.c b/extension/maxminddb.c
@@ -737,6 +737,7 @@ PyMODINIT_FUNC PyInit_extension(void) {
     if (PyType_Ready(&Metadata_Type)) {
         return NULL;
     }
+    Py_INCREF(&Metadata_Type);
     PyModule_AddObject(m, "Metadata", (PyObject *)&Metadata_Type);
 
     PyObject *error_mod = PyImport_ImportModule("maxminddb.errors");

Original file line number	Diff line number	Diff line change
`@@ -737,6 +737,7 @@ PyMODINIT_FUNC PyInit_extension(void) {`
`737`	`737`	`if (PyType_Ready(&Metadata_Type)) {`
`738`	`738`	`return NULL;`
`739`	`739`	`}`
	`740`	`+ Py_INCREF(&Metadata_Type);`
`740`	`741`	`PyModule_AddObject(m, "Metadata", (PyObject *)&Metadata_Type);`
`741`	`742`
`742`	`743`	`PyObject *error_mod = PyImport_ImportModule("maxminddb.errors");`