remove spread operator in object diffs to increase performance

Author: SheneekaW

src/added/index.js

@@ -13,10 +13,12 @@ const addedDiff = (lhs, rhs) => {
 
       if (isObject(difference) && isEmpty(difference)) return acc;
 
-      return { ...acc, [key]: difference };
+      acc[key] = difference;
+      return acc;
     }
 
-    return { ...acc, [key]: r[key] };
+    acc[key] = r[key];
+    return acc;
   }, {});
 };
 

src/added/index.test.js

@@ -15,6 +15,7 @@ describe('.addedDiff', () => {
         ['function', () => ({})],
         ['date', new Date()],
       ])('returns empty object when given values of type %s are equal', (type, value) => {
+        console.log('here yub')
         expect(addedDiff(value, value)).toEqual({});
       });
     });

src/deleted/index.js

@@ -12,10 +12,12 @@ const deletedDiff = (lhs, rhs) => {
 
       if (isObject(difference) && isEmpty(difference)) return acc;
 
-      return { ...acc, [key]: difference };
+      acc[key] = difference;
+      return acc;
     }
 
-    return { ...acc, [key]: undefined };
+    acc[key] = undefined;
+    return acc;
   }, {});
 };
 

src/diff/index.js

@@ -9,7 +9,12 @@ const diff = (lhs, rhs) => {
   const r = properObject(rhs);
 
   const deletedValues = Object.keys(l).reduce((acc, key) => {
-    return r.hasOwnProperty(key) ? acc : { ...acc, [key]: undefined };
+    if (!r.hasOwnProperty(key)) {
+      acc[key] = undefined;
+      
+    }
+
+    return acc;
   }, {});
 
   if (isDate(l) || isDate(r)) {
@@ -18,13 +23,17 @@ const diff = (lhs, rhs) => {
   }
 
   return Object.keys(r).reduce((acc, key) => {
-    if (!l.hasOwnProperty(key)) return { ...acc, [key]: r[key] }; // return added r key
+    if (!l.hasOwnProperty(key)){
+      acc[key] = r[key]; // return added r key
+      return acc;
+    } 
 
     const difference = diff(l[key], r[key]);
 
     if (isObject(difference) && isEmpty(difference) && !isDate(difference)) return acc; // return no diff
 
-    return { ...acc, [key]: difference }; // return updated key
+    acc[key] = difference // return updated key
+    return acc; // return updated key
   }, deletedValues);
 };
 

src/updated/index.js

@@ -21,7 +21,8 @@ const updatedDiff = (lhs, rhs) => {
 
       if (isObject(difference) && isEmpty(difference) && !isDate(difference)) return acc;
 
-      return { ...acc, [key]: difference };
+      acc[key] = difference;
+      return acc;
     }
 
     return acc;