Add problem matchers; Also run Vulture

Author: rahul-deepsource

.github/flake8.json

@@ -0,0 +1,18 @@
+{
+  "problemMatcher": [
+    {
+      "severity": "warning",
+      "pattern": [
+        {
+          "regexp": "^(\\033\\[0m)?([^:]+):(\\d+):(\\d+): ([A-Z]\\d{3}) (.*)$",
+          "file": 2,
+          "line": 3,
+          "column": 4,
+          "code": 5,
+          "message": 6
+        }
+      ],
+      "owner": "flake8"
+    }
+  ]
+}

.github/mypy.json

@@ -0,0 +1,17 @@
+{
+  "problemMatcher": [
+    {
+      "pattern": [
+        {
+          "regexp": "^(\\033\\[0m)?([^:]+):(\\d+): ([^:]+): (.*)  \\[(.*)\\]$",
+          "file": 2,
+          "line": 3,
+          "severity": 4,
+          "message": 5,
+          "code": 6
+        }
+      ],
+      "owner": "mypy"
+    }
+  ]
+}

.github/pylint-error.json

@@ -0,0 +1,18 @@
+{
+  "problemMatcher": [
+    {
+      "severity": "error",
+      "pattern": [
+        {
+          "regexp": "^([^:]+):(\\d+):(\\d+): (E\\d+): \\033\\[[\\d;]+m([^\\033]+).*$",
+          "file": 1,
+          "line": 2,
+          "column": 3,
+          "code": 4,
+          "message": 5
+        }
+      ],
+      "owner": "pylint-error"
+    }
+  ]
+}

.github/pylint-warning.json

@@ -0,0 +1,18 @@
+{
+  "problemMatcher": [
+    {
+      "severity": "warning",
+      "pattern": [
+        {
+          "regexp": "^([^:]+):(\\d+):(\\d+): ([A-DF-Z]\\d+): \\033\\[[\\d;]+m([^\\033]+).*$",
+          "file": 1,
+          "line": 2,
+          "column": 3,
+          "code": 4,
+          "message": 5
+        }
+      ],
+      "owner": "pylint-warning"
+    }
+  ]
+}

.github/vulture.json

@@ -0,0 +1,16 @@
+{
+  "problemMatcher": [
+    {
+      "severity": "warning",
+      "pattern": [
+        {
+          "regexp": "^([^:]+):(\\d+): ([^(]+ \\(\\d+% confidence\\))$",
+          "file": 1,
+          "line": 2,
+          "message": 3
+        }
+      ],
+      "owner": "vulture"
+    }
+  ]
+}

.github/workflows/all-lints.yml

@@ -8,6 +8,4 @@ jobs:
 
     steps:
       - uses: actions/checkout@v1
-      - uses: ricardochaves/python-lint@master
-        with:
-          python-root-list: "tests"
+      - uses: rahul-deepsource/plint@master

action.yml

@@ -4,7 +4,7 @@ inputs:
   python-root-list:
     description: "A list of all paths to test"
     required: false
-    default: "."
+    default: "./**/*.py"
   use-pylint:
     description: "Use Pylint"
     required: false
@@ -29,6 +29,10 @@ inputs:
     description: "Use isort"
     required: false
     default: true
+  use-vulture:
+    description: "Use vulture"
+    required: false
+    default: true
   extra-pylint-options:
     description: "Extra options: pylint $(extra-pylint-options) $(python-root-list)"
     required: false
@@ -53,6 +57,10 @@ inputs:
     description: "Extra options: isort -rc $(extra-isort-options) $(python-root-list) -c --diff "
     required: false
     default: ""
+  extra-vulture-options:
+    description: "Extra options: vulture $(extra-vulture-options) $(python-root-list)"
+    required: false
+    default: ""
 
 runs:
   using: "docker"
@@ -65,12 +73,14 @@ runs:
     - ${{ inputs.use-black }}
     - ${{ inputs.use-mypy }}
     - ${{ inputs.use-isort }}
+    - ${{ inputs.use-vulture }}
     - ${{ inputs.extra-pylint-options }}
     - ${{ inputs.extra-pycodestyle-options }}
     - ${{ inputs.extra-flake8-options }}
     - ${{ inputs.extra-black-options }}
     - ${{ inputs.extra-mypy-options }}
     - ${{ inputs.extra-isort-options }}
+    - ${{ inputs.extra-vulture-options }}
 branding:
   icon: "terminal"
   color: "white"

entrypoint.sh

@@ -9,24 +9,28 @@
 # $5 - use-black
 # $6 - use-mypy
 # $7 - use-isort
-# $8 - extra-pylint-options
-# $9 - extra-pycodestyle-options
-# ${10} - extra-flake8-options
-# ${11} - extra-black-options
-# ${12} - extra-mypy-options
-# ${13} - extra-isort-options
+# $8 - use-vulture
+# $9 - extra-pylint-options
+# ${10} - extra-pycodestyle-options
+# ${11} - extra-flake8-options
+# ${12} - extra-black-options
+# ${13} - extra-mypy-options
+# ${14} - extra-isort-options
+# ${15} - extra-vulture-options
 
 if [ "$2" = true ] ; then
 
-    echo Running: pylint $8 $1
+    echo Running: pylint $9 $1
 
-    pylint $8 $1
+    pylint $9 $1
     exit_code=$?
 
     if [ "$exit_code" = "0" ]; then
         echo "Pylint ok"
     else
         echo "Pylint error"
+        echo "::add-matcher::$(pwd)/.github/pylint-error.json"
+        echo "::add-matcher::$(pwd)/.github/pylint-warning.json"
         exit $exit_code
     fi
 
@@ -35,9 +39,9 @@ fi
 
 if [ "$3" = true ] ; then
 
-    echo Running: pycodestyle $9 $1
+    echo Running: pycodestyle ${10} $1
 
-    pycodestyle $9 $1
+    pycodestyle ${10} $1
     exit_code=$?
 
     if [ "$exit_code" = "0" ]; then
@@ -51,25 +55,26 @@ fi
 
 if [ "$4" = true ] ; then
 
-    echo Running: flake8 ${10} $1
+    echo Running: flake8 ${11} $1
 
-    flake8 ${10} $1
+    flake8 ${11} $1
     exit_code=$?
 
     if [ "$exit_code" = "0" ]; then
         echo "Flake8 ok"
     else
         echo "Flake8 error"
+        echo "::add-matcher::$(pwd)/.github/flake8.json"
         exit $exit_code
     fi
 
 fi
 
 if [ "$5" = true ] ; then
 
-    echo Running: black --check ${11} $1
+    echo Running: black --check ${12} $1
 
-    black --check ${11} $1
+    black --check ${12} $1
     exit_code=$?
 
     if [ "$exit_code" = "0" ]; then
@@ -83,25 +88,26 @@ fi
 
 if [ "$6" = true ] ; then
 
-    echo Running: mypy ${12} $1
+    echo Running: mypy ${13} $1
 
-    mypy ${12} $1
+    mypy ${13} $1
     exit_code=$?
 
     if [ "$exit_code" = "0" ]; then
         echo "mypy ok"
     else
         echo "mypy error"
+        echo "::add-matcher::$(pwd)/.github/mypy.json"
         exit $exit_code
     fi
 
 fi
 
 if [ "$7" = true ] ; then
 
-    echo Running: isort ${13} $1 -c --diff
+    echo Running: isort ${14} $1 -c --diff
 
-    isort ${13} $1 -c --diff
+    isort ${14} $1 -c --diff
     exit_code=$?
 
     if [ "$exit_code" = "0" ]; then
@@ -111,4 +117,21 @@ if [ "$7" = true ] ; then
         exit $exit_code
     fi
 
-fi
+fi
+
+if [ "$8" = true ] ; then
+
+    echo Running: vulture ${15} $1
+
+    vulture ${15} $1
+    exit_code=$?
+
+    if [ "$exit_code" = "0" ]; then
+        echo "vulture ok"
+    else
+        echo "vulture error"
+        echo "::add-matcher::$(pwd)/.github/vulture.json"
+        exit $exit_code
+    fi
+
+fi