Skip to content

Commit 70c91ac

Browse files
authored
Merge pull request #13 from sawa-zen/fix/tabindex
fix: patch tabindex rule
2 parents 0c182d9 + cac30a4 commit 70c91ac

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

lib/rules/tabindex-no-positive.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,9 @@ module.exports = {
2323
create (context) {
2424
return VueUtils.defineTemplateBodyVisitor(context, {
2525
"VAttribute" (node) {
26-
let tabindex;
27-
if (node.directive) {
28-
tabindex = node.key.argument.name === 'tabindex';
29-
} else {
30-
tabindex = node.key.name === 'tabindex';
31-
}
32-
33-
if (!tabindex) {
26+
const isTabindex = (!node.directive && node.key.name === 'tabindex')
27+
|| (node.key.name.name === 'bind' && node.key.argument.name === 'tabindex')
28+
if (!isTabindex) {
3429
return;
3530
}
3631

tests/lib/rules/tabindex-no-positive.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ tester.run('tabindex-no-positive', rule, {
2323
filename: 'test.vue',
2424
code: '<template><span tabindex="0"></span></template>',
2525
},
26+
{
27+
filename: 'test.vue',
28+
code: '<template><span v-if="true" tabindex="0"></span></template>',
29+
},
2630
{
2731
filename: 'test.vue',
2832
code: '<template><span tabindex="-1"></span></template>',

0 commit comments

Comments
 (0)