From 1832b9ca4835869415b09270f007b85d58cf2462 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Mon, 14 Dec 2020 17:49:02 +0500 Subject: [PATCH 01/23] Spellings mistake --- app/code/Magento/Checkout/Model/Session.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/code/Magento/Checkout/Model/Session.php b/app/code/Magento/Checkout/Model/Session.php index 0addbf069cba3..eec5c1c967ef0 100644 --- a/app/code/Magento/Checkout/Model/Session.php +++ b/app/code/Magento/Checkout/Model/Session.php @@ -260,7 +260,7 @@ public function getQuote() } /** - * If current currency code of quote is not equal current currency code of store, + * If current currency code of quote is not equal to current currency code of store, * need recalculate totals of quote. It is possible if customer use currency switcher or * store switcher. */ @@ -268,8 +268,8 @@ public function getQuote() $quote->setStore($this->_storeManager->getStore()); $this->quoteRepository->save($quote->collectTotals()); /* - * We mast to create new quote object, because collectTotals() - * can to create links with other objects. + * We must to create new quote object, because collectTotals() + * can create links with other objects. */ $quote = $this->quoteRepository->get($this->getQuoteId()); } From fe500449c055095f0764180aba8693ee72f4c0ac Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:04:03 +0500 Subject: [PATCH 02/23] Update ImagesConfigFactoryInterface.php --- .../Model/Product/Gallery/ImagesConfigFactoryInterface.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/code/Magento/Catalog/Model/Product/Gallery/ImagesConfigFactoryInterface.php b/app/code/Magento/Catalog/Model/Product/Gallery/ImagesConfigFactoryInterface.php index 7a656951f8b56..82860a1f89ea9 100644 --- a/app/code/Magento/Catalog/Model/Product/Gallery/ImagesConfigFactoryInterface.php +++ b/app/code/Magento/Catalog/Model/Product/Gallery/ImagesConfigFactoryInterface.php @@ -5,6 +5,11 @@ */ namespace Magento\Catalog\Model\Product\Gallery; +/** + * Interface ImagesConfigFactoryInterface + * + * @api + */ interface ImagesConfigFactoryInterface { /** From d979119e274f6fd8c505e1ce0939f34515eb8bbe Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:23:17 +0500 Subject: [PATCH 03/23] Update EntityMetadataInterface.php --- .../Magento/Framework/EntityManager/EntityMetadataInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/EntityMetadataInterface.php b/lib/internal/Magento/Framework/EntityManager/EntityMetadataInterface.php index ce19f76663721..8e4ba816d1f1c 100644 --- a/lib/internal/Magento/Framework/EntityManager/EntityMetadataInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/EntityMetadataInterface.php @@ -8,6 +8,7 @@ /** * Interface EntityMetadataInterface + * @deprecated 103.0.1 */ interface EntityMetadataInterface { From a086c104bc09bfa24896c318b1496df10da89945 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:25:56 +0500 Subject: [PATCH 04/23] Update HydratorInterface.php --- .../Magento/Framework/EntityManager/HydratorInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/HydratorInterface.php b/lib/internal/Magento/Framework/EntityManager/HydratorInterface.php index a55782914a0db..f88e03dea01ea 100644 --- a/lib/internal/Magento/Framework/EntityManager/HydratorInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/HydratorInterface.php @@ -8,6 +8,7 @@ /** * Interface HydratorInterface + * @deprecated 103.0.1 */ interface HydratorInterface { From ff94bd43298d2c3fed524828295564f09819d382 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:33:38 +0500 Subject: [PATCH 05/23] Update MapperInterface.php --- lib/internal/Magento/Framework/EntityManager/MapperInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/MapperInterface.php b/lib/internal/Magento/Framework/EntityManager/MapperInterface.php index 62a0534cf7f68..15acc840d09b1 100644 --- a/lib/internal/Magento/Framework/EntityManager/MapperInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/MapperInterface.php @@ -7,6 +7,7 @@ /** * MapperInterface + * @deprecated */ interface MapperInterface { From 3de525b5958da635c559d85196f7a6f34de86226 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:34:11 +0500 Subject: [PATCH 06/23] Update AttributeInterface.php --- .../Framework/EntityManager/Operation/AttributeInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/Operation/AttributeInterface.php b/lib/internal/Magento/Framework/EntityManager/Operation/AttributeInterface.php index 36ac093fba783..c4c86e75e10e4 100644 --- a/lib/internal/Magento/Framework/EntityManager/Operation/AttributeInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/Operation/AttributeInterface.php @@ -8,6 +8,7 @@ /** * Interface AttributeInterface + * @deprecated */ interface AttributeInterface { From 6c74f466fe132b0478a4b8b877a78d875f8b916c Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:34:42 +0500 Subject: [PATCH 07/23] Update CheckIfExistsInterface.php --- .../Framework/EntityManager/Operation/CheckIfExistsInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/Operation/CheckIfExistsInterface.php b/lib/internal/Magento/Framework/EntityManager/Operation/CheckIfExistsInterface.php index 03bb22d06ee40..000d38ee05100 100644 --- a/lib/internal/Magento/Framework/EntityManager/Operation/CheckIfExistsInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/Operation/CheckIfExistsInterface.php @@ -9,6 +9,7 @@ /** * Interface for checking if entity exists + * @deprecated */ interface CheckIfExistsInterface extends OperationInterface { From bd24ebe66ea633c211b891f0995daea0d9721e45 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:35:04 +0500 Subject: [PATCH 08/23] Update CreateInterface.php --- .../Framework/EntityManager/Operation/CreateInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/Operation/CreateInterface.php b/lib/internal/Magento/Framework/EntityManager/Operation/CreateInterface.php index dea1c0b672d6e..65c069b5d6960 100644 --- a/lib/internal/Magento/Framework/EntityManager/Operation/CreateInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/Operation/CreateInterface.php @@ -9,6 +9,7 @@ /** * Interface for creating entity + * @deprecated */ interface CreateInterface extends OperationInterface { From d13cb98a8a887a624476b955dda3842b98c9fe8c Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:35:39 +0500 Subject: [PATCH 09/23] Update DeleteInterface.php --- .../Framework/EntityManager/Operation/DeleteInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/Operation/DeleteInterface.php b/lib/internal/Magento/Framework/EntityManager/Operation/DeleteInterface.php index 2817825d03ff2..d74a34857802f 100644 --- a/lib/internal/Magento/Framework/EntityManager/Operation/DeleteInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/Operation/DeleteInterface.php @@ -9,6 +9,7 @@ /** * Interface for deleting entity + * @deprecated */ interface DeleteInterface extends OperationInterface { From 3ce483a0f7560798a7945ed470a973b3af377cb1 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:36:09 +0500 Subject: [PATCH 10/23] Update ExtensionInterface.php --- .../Framework/EntityManager/Operation/ExtensionInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/Operation/ExtensionInterface.php b/lib/internal/Magento/Framework/EntityManager/Operation/ExtensionInterface.php index 2138b102b31fe..d925fe97bcea0 100644 --- a/lib/internal/Magento/Framework/EntityManager/Operation/ExtensionInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/Operation/ExtensionInterface.php @@ -7,6 +7,7 @@ /** * Interface ExtensionInterface + * @deprecated */ interface ExtensionInterface { From ec99462790cf07a07e3bd96d0727849476bc7ac7 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:36:36 +0500 Subject: [PATCH 11/23] Update ReadInterface.php --- .../Magento/Framework/EntityManager/Operation/ReadInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/Operation/ReadInterface.php b/lib/internal/Magento/Framework/EntityManager/Operation/ReadInterface.php index 6f00c61339cb6..03723cf06fedc 100644 --- a/lib/internal/Magento/Framework/EntityManager/Operation/ReadInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/Operation/ReadInterface.php @@ -9,6 +9,7 @@ /** * Interface for reading entity data + * @deprecated */ interface ReadInterface extends OperationInterface { From 5b6ee2241a725ef5ff94fd996186cf781f010c4c Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:37:05 +0500 Subject: [PATCH 12/23] Update UpdateInterface.php --- .../Framework/EntityManager/Operation/UpdateInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/Operation/UpdateInterface.php b/lib/internal/Magento/Framework/EntityManager/Operation/UpdateInterface.php index 13838388bc3d4..86751327f962d 100644 --- a/lib/internal/Magento/Framework/EntityManager/Operation/UpdateInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/Operation/UpdateInterface.php @@ -9,6 +9,7 @@ /** * Interface for updating entity + * @deprecated */ interface UpdateInterface extends OperationInterface { From 17d39a09480319c6e05ada62c8cd18ab3c0f00e1 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:39:03 +0500 Subject: [PATCH 13/23] Update OperationInterface.php --- .../Magento/Framework/EntityManager/OperationInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/OperationInterface.php b/lib/internal/Magento/Framework/EntityManager/OperationInterface.php index 8fe29a6fad9a6..413fa821fc8e5 100644 --- a/lib/internal/Magento/Framework/EntityManager/OperationInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/OperationInterface.php @@ -7,6 +7,7 @@ /** * Marker interface for entity manager operations. + * @deprecated this component was never finished and not recommended for usage */ interface OperationInterface { From 3c0a65f99744d855fa7ae9c446952015ff7f454d Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:40:55 +0500 Subject: [PATCH 14/23] Update Context.php --- lib/internal/Magento/Framework/App/Helper/Context.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/internal/Magento/Framework/App/Helper/Context.php b/lib/internal/Magento/Framework/App/Helper/Context.php index 5b90df8c55205..0e02762f8e3a6 100644 --- a/lib/internal/Magento/Framework/App/Helper/Context.php +++ b/lib/internal/Magento/Framework/App/Helper/Context.php @@ -17,6 +17,8 @@ * * As Magento moves from inheritance-based APIs all such classes will be deprecated together with * the classes they were introduced for. + * + * @deprecated */ class Context implements \Magento\Framework\ObjectManager\ContextInterface { From 9589ae749d834d4a9d54ca4b9e3eee4a16f820d9 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:41:38 +0500 Subject: [PATCH 15/23] Update ExtensionInterface.php --- .../Framework/EntityManager/Operation/ExtensionInterface.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/EntityManager/Operation/ExtensionInterface.php b/lib/internal/Magento/Framework/EntityManager/Operation/ExtensionInterface.php index 2138b102b31fe..d925fe97bcea0 100644 --- a/lib/internal/Magento/Framework/EntityManager/Operation/ExtensionInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/Operation/ExtensionInterface.php @@ -7,6 +7,7 @@ /** * Interface ExtensionInterface + * @deprecated */ interface ExtensionInterface { From 448ab9ced32a0e685158e72951c85217f9b45c69 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 10 Mar 2021 15:42:45 +0500 Subject: [PATCH 16/23] Update EntityManager.php --- lib/internal/Magento/Framework/EntityManager/EntityManager.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/internal/Magento/Framework/EntityManager/EntityManager.php b/lib/internal/Magento/Framework/EntityManager/EntityManager.php index 1adb03cdfb1a4..bace7892e24d7 100644 --- a/lib/internal/Magento/Framework/EntityManager/EntityManager.php +++ b/lib/internal/Magento/Framework/EntityManager/EntityManager.php @@ -22,6 +22,8 @@ * * For filtering operations, it's recommended to use successor of * Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection class. + * + * @deprecated */ class EntityManager { From 4a7f96e10a8767bc23f0dcd949f1a92164183b6b Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 17 Mar 2021 16:42:43 +0500 Subject: [PATCH 17/23] Version Removed --- .../Magento/Framework/EntityManager/EntityMetadataInterface.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/internal/Magento/Framework/EntityManager/EntityMetadataInterface.php b/lib/internal/Magento/Framework/EntityManager/EntityMetadataInterface.php index 8e4ba816d1f1c..29d0abe53bc8f 100644 --- a/lib/internal/Magento/Framework/EntityManager/EntityMetadataInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/EntityMetadataInterface.php @@ -8,7 +8,7 @@ /** * Interface EntityMetadataInterface - * @deprecated 103.0.1 + * @deprecated */ interface EntityMetadataInterface { From a64886e1d0a6959b0cfa35882496051bed648008 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 17 Mar 2021 16:43:25 +0500 Subject: [PATCH 18/23] Update ContextInterface.php --- app/code/Magento/Catalog/Model/Layer/ContextInterface.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/code/Magento/Catalog/Model/Layer/ContextInterface.php b/app/code/Magento/Catalog/Model/Layer/ContextInterface.php index 00aec9db66f7a..6af8df9238707 100644 --- a/app/code/Magento/Catalog/Model/Layer/ContextInterface.php +++ b/app/code/Magento/Catalog/Model/Layer/ContextInterface.php @@ -16,6 +16,8 @@ * * As Magento moves from inheritance-based APIs all such classes will be deprecated together with their * corresponding abstract classes. + * + * @deprecated */ interface ContextInterface { From 2612d2f28e2f19bf4ed204fac0f4e70445d138c5 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 17 Mar 2021 16:44:33 +0500 Subject: [PATCH 19/23] Update HydratorInterface.php --- .../Magento/Framework/EntityManager/HydratorInterface.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/internal/Magento/Framework/EntityManager/HydratorInterface.php b/lib/internal/Magento/Framework/EntityManager/HydratorInterface.php index f88e03dea01ea..7a6b8d5b5e81b 100644 --- a/lib/internal/Magento/Framework/EntityManager/HydratorInterface.php +++ b/lib/internal/Magento/Framework/EntityManager/HydratorInterface.php @@ -8,7 +8,7 @@ /** * Interface HydratorInterface - * @deprecated 103.0.1 + * @deprecated */ interface HydratorInterface { From 2a09f121baa55653fb37245aecd99a9dc8ba2531 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 17 Mar 2021 16:45:53 +0500 Subject: [PATCH 20/23] Update ImagesConfigFactoryInterface.php --- .../Model/Product/Gallery/ImagesConfigFactoryInterface.php | 1 - 1 file changed, 1 deletion(-) diff --git a/app/code/Magento/Catalog/Model/Product/Gallery/ImagesConfigFactoryInterface.php b/app/code/Magento/Catalog/Model/Product/Gallery/ImagesConfigFactoryInterface.php index 82860a1f89ea9..2363fb8cc45de 100644 --- a/app/code/Magento/Catalog/Model/Product/Gallery/ImagesConfigFactoryInterface.php +++ b/app/code/Magento/Catalog/Model/Product/Gallery/ImagesConfigFactoryInterface.php @@ -7,7 +7,6 @@ /** * Interface ImagesConfigFactoryInterface - * * @api */ interface ImagesConfigFactoryInterface From 5171678495215ccbd7d20a5d4c81247dd009661a Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 17 Mar 2021 17:31:32 +0500 Subject: [PATCH 21/23] Update CurrentCustomer.php --- app/code/Magento/Customer/Helper/Session/CurrentCustomer.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/code/Magento/Customer/Helper/Session/CurrentCustomer.php b/app/code/Magento/Customer/Helper/Session/CurrentCustomer.php index d48ff5918c3f3..73de6fb1e50ae 100644 --- a/app/code/Magento/Customer/Helper/Session/CurrentCustomer.php +++ b/app/code/Magento/Customer/Helper/Session/CurrentCustomer.php @@ -15,6 +15,8 @@ /** * Class CurrentCustomer + * @deprecated use \Magento\Customer\Model\Session + * * @SuppressWarnings(PHPMD.CookieAndSessionMisuse) */ class CurrentCustomer From b73d747827a3fd92f8f2fd228340d7212a20d567 Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 17 Mar 2021 17:34:59 +0500 Subject: [PATCH 22/23] Update Data.php --- lib/internal/Magento/Framework/Url/Helper/Data.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/internal/Magento/Framework/Url/Helper/Data.php b/lib/internal/Magento/Framework/Url/Helper/Data.php index bb69ce9946c2a..801cd17c608fe 100644 --- a/lib/internal/Magento/Framework/Url/Helper/Data.php +++ b/lib/internal/Magento/Framework/Url/Helper/Data.php @@ -8,6 +8,8 @@ * Core URL helper * * @author Magento Core Team + * + * @deprecated Use @api \Magento\Framework\Url\EncoderInterface::encode and \Magento\Framework\UrlInterface::getCurrentUrl */ namespace Magento\Framework\Url\Helper; From 5e9a4d59d70280e01b66c0a6aaa27bd8ed134aaa Mon Sep 17 00:00:00 2001 From: Ejaz Alam Date: Wed, 17 Mar 2021 17:37:38 +0500 Subject: [PATCH 23/23] Update ZendClient.php --- lib/internal/Magento/Framework/HTTP/ZendClient.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/internal/Magento/Framework/HTTP/ZendClient.php b/lib/internal/Magento/Framework/HTTP/ZendClient.php index f88e6fabcb6f1..cb5b7e684d2ef 100644 --- a/lib/internal/Magento/Framework/HTTP/ZendClient.php +++ b/lib/internal/Magento/Framework/HTTP/ZendClient.php @@ -8,6 +8,7 @@ * Magento HTTP Client * * @author Magento Core Team + * @deprecated Use \Magento\Framework\HTTP\ClientInterface */ namespace Magento\Framework\HTTP;