From df6c294861e48ee81dcf4de0c1dec3986d6c09bc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C5=81ukasz=20Bajsarowicz?= <lukasz.bajsarowicz@gmail.com>
Date: Thu, 28 Nov 2019 17:04:36 +0100
Subject: [PATCH] REFACTOR: Extract Action Groups to separate files (according
 to MFTF best practices)

---
 .../GenerateOrderReportActionGroup.xml        | 20 +------------
 ...rateOrderReportForNotCancelActionGroup.xml | 28 +++++++++++++++++++
 2 files changed, 29 insertions(+), 19 deletions(-)
 create mode 100644 app/code/Magento/Reports/Test/Mftf/ActionGroup/GenerateOrderReportForNotCancelActionGroup.xml

diff --git a/app/code/Magento/Reports/Test/Mftf/ActionGroup/GenerateOrderReportActionGroup.xml b/app/code/Magento/Reports/Test/Mftf/ActionGroup/GenerateOrderReportActionGroup.xml
index 29bbe91afbd11..1250c7b0ac370 100644
--- a/app/code/Magento/Reports/Test/Mftf/ActionGroup/GenerateOrderReportActionGroup.xml
+++ b/app/code/Magento/Reports/Test/Mftf/ActionGroup/GenerateOrderReportActionGroup.xml
@@ -16,29 +16,11 @@
             <argument name="orderFromDate" type="string"/>
             <argument name="orderToDate" type="string"/>
         </arguments>
-        
+
         <click selector="{{OrderReportMainSection.here}}" stepKey="clickOnHere"/>
         <fillField selector="{{OrderReportFilterSection.dateFrom}}" userInput="{{orderFromDate}}" stepKey="fillFromDate"/>
         <fillField selector="{{OrderReportFilterSection.dateTo}}" userInput="{{orderToDate}}" stepKey="fillToDate"/>
         <selectOption selector="{{OrderReportFilterSection.orderStatus}}" userInput="Any" stepKey="selectAnyOption"/>
         <click selector="{{OrderReportMainSection.showReport}}" stepKey="showReport"/>
     </actionGroup>
-    
-    <actionGroup name="GenerateOrderReportForNotCancelActionGroup">
-        <annotations>
-            <description>Clicks on 'here' to refresh the grid data. Enters the provided Order From/To Dates and provided Order Status. Clicks on 'Show Report'.</description>
-        </annotations>
-        <arguments>
-            <argument name="orderFromDate" type="string"/>
-            <argument name="orderToDate" type="string"/>
-            <argument name="statuses" type="string"/>
-        </arguments>
-        
-        <click selector="{{OrderReportMainSection.here}}" stepKey="clickOnHere"/>
-        <fillField selector="{{OrderReportFilterSection.dateFrom}}" userInput="{{orderFromDate}}" stepKey="fillFromDate"/>
-        <fillField selector="{{OrderReportFilterSection.dateTo}}" userInput="{{orderToDate}}" stepKey="fillToDate"/>
-        <selectOption selector="{{OrderReportFilterSection.orderStatus}}" userInput="Specified" stepKey="selectSpecifiedOption"/>
-        <selectOption selector="{{OrderReportFilterSection.orderStatusSpecified}}" parameterArray="{{statuses}}" stepKey="selectSpecifiedOptionStatus"/>
-        <click selector="{{OrderReportMainSection.showReport}}" stepKey="showReport"/>
-    </actionGroup>
 </actionGroups>
diff --git a/app/code/Magento/Reports/Test/Mftf/ActionGroup/GenerateOrderReportForNotCancelActionGroup.xml b/app/code/Magento/Reports/Test/Mftf/ActionGroup/GenerateOrderReportForNotCancelActionGroup.xml
new file mode 100644
index 0000000000000..32c82308c8f99
--- /dev/null
+++ b/app/code/Magento/Reports/Test/Mftf/ActionGroup/GenerateOrderReportForNotCancelActionGroup.xml
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="GenerateOrderReportForNotCancelActionGroup">
+        <annotations>
+            <description>Clicks on 'here' to refresh the grid data. Enters the provided Order From/To Dates and provided Order Status. Clicks on 'Show Report'.</description>
+        </annotations>
+        <arguments>
+            <argument name="orderFromDate" type="string"/>
+            <argument name="orderToDate" type="string"/>
+            <argument name="statuses" type="string"/>
+        </arguments>
+
+        <click selector="{{OrderReportMainSection.here}}" stepKey="clickOnHere"/>
+        <fillField selector="{{OrderReportFilterSection.dateFrom}}" userInput="{{orderFromDate}}" stepKey="fillFromDate"/>
+        <fillField selector="{{OrderReportFilterSection.dateTo}}" userInput="{{orderToDate}}" stepKey="fillToDate"/>
+        <selectOption selector="{{OrderReportFilterSection.orderStatus}}" userInput="Specified" stepKey="selectSpecifiedOption"/>
+        <selectOption selector="{{OrderReportFilterSection.orderStatusSpecified}}" parameterArray="{{statuses}}" stepKey="selectSpecifiedOptionStatus"/>
+        <click selector="{{OrderReportMainSection.showReport}}" stepKey="showReport"/>
+    </actionGroup>
+</actionGroups>