Skip to content

fixed the block names in an admin form #39660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from
Open

fixed the block names in an admin form #39660

wants to merge 3 commits into from

Conversation

haijerome
Copy link

@haijerome haijerome commented Feb 26, 2025 •
edited by m2-assistant bot
Loading

Noticed the admin product attribute form layout has mistyped block names for Manage Options (Values of Your Attribute) and Advanced Attribute Properties in the product attribute form. Just fixed the block names appropriately.

New-Product-Attribute-Product-Attributes-Attributes-Stores-Magento-Admin-02-26-2025_08_49_PM

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] fixed the block names in an admin form #39701: fixed the block names in an admin form

@haijerome
fixed the block names in an admin form
aff7ba5 
Noticed the admin product attribute form layout has mistyped block names for `Manage Options (Values of Your Attribute)` and `Advanced Attribute Properties` in the product attribute form. Just fixed the block names appropriately.
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Feb 26, 2025

Hi @haijerome. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@haijerome
Copy link
Author

@magento run all tests

@haijerome
Merge branch 'magento:2.4-develop' into fixed-block-names-admin-produ…
3726217 
…ct-attribute-form
@haijerome
replaced copyright information with Adobe to pass the static tests
8f33ca4 
Just replaced Magento Copyright information with Adobe to pass the static tests.
haijerome
haijerome commented Feb 27, 2025
View reviewed changes
Copy link
Author

@haijerome haijerome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced the magento copyright information with Adobe to pass the static tests

@haijerome
Copy link
Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 4, 2025
Open
5 tasks
@engcom-Hotel engcom-Hotel added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Priority: P3 May be fixed according to the position in the backlog. labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: P3 May be fixed according to the position in the backlog. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] fixed the block names in an admin form
2 participants
@haijerome @engcom-Hotel