Skip to content

#39604 Fixed rendering products list after applying filters #39686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from
Open

#39604 Fixed rendering products list after applying filters #39686

wants to merge 5 commits into from

Conversation

sydor-dev
Copy link

@sydor-dev sydor-dev commented Feb 28, 2025 •
edited by m2-assistant bot
Loading

Description (*)

The issue occures after Ajax request to

/index.php/backend/mui/index/render/?isAjax=true

After doing all steps to reproduce Request Payload contains paging[notLimits]: 1 and no other limits. It means that BackEnd shoud return all Products excluding selected
actual_result

Filters should be preserved to prevent overloading
expected_result

Manual testing scenarios (*)

  1. Go to the Product Edit Page
  2. Select "Related Products, Up-Sells, and Cross-Sells"
  3. Press "Add Related Products"
  4. Set Configuration as it shown in the image
    preconditions_1
    Important: 1 or more products should be unselected
  5. Press "Add Selected Products"

Expected result

Selected Products added in amount of 58 items. Request completed

Actual result

No products added. Page freezes

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] #39604 Fixed rendering products list after applying filters #39699: Error: Script error for "Magento_Catalog/js/validate-product" for admin content pagebuilder with products load #39604 Fixed rendering products list after applying filters

@sydor-dev
magento#39604 Fixed rendering products list after applying filters
0df8506 
- Preserve previously applied filters for Ajax request
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Feb 28, 2025

Hi @sydor-dev. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Feb 28, 2025
@sydor-dev
Copy link
Author

@magento run all tests

1 similar comment
@sydor-dev
Copy link
Author

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 4, 2025
Open
5 tasks
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 4, 2025
@sydor-dev
Copy link
Author

@magento run all tests

@sydor-dev
Copy link
Author

@magento run all tests

@engcom-Charlie engcom-Charlie moved this to Pending Review in Community Dashboard Apr 10, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel moved this from Pending Review to Review in Progress in Community Dashboard Apr 10, 2025
@engcom-Charlie engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Apr 10, 2025
@engcom-Charlie engcom-Charlie moved this from Review in Progress to Pending Review in Community Dashboard Apr 10, 2025
@engcom-Hotel engcom-Hotel moved this from Pending Review to Review in Progress in Community Dashboard Apr 10, 2025
engcom-Hotel
engcom-Hotel requested changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sydor-dev,

Thanks for the contribution!

Please look into the functional tests failures, it seems they are failing due to code changes.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Apr 10, 2025
@rostilos
Copy link
Contributor

@magento run Functional Tests CE

@engcom-Dash engcom-Dash self-assigned this Apr 25, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

Hello @sydor-dev,

Thank you for the contribution!

While reviewing and testing the code changes, we noticed that a few existing functionalities are being affected, and due to that some functional test cases are also failing. Could you please take a look at it and fix it?

Thanks

@engcom-Dash
Copy link
Contributor

Hello @sydor-dev,

We appreciate your contribution!

Since we haven't received a response from you for an extended period, we are closing this PR for now.

Whenever you're ready to resume work on this, please feel free to reopen it or request us to do so. We'll be more than happy to assist you.

Thanks once again!

@sydor-dev
Copy link
Author

@engcom-Dash Hi, could you please reopen this PR? I'm ready to continue working on it. Thank you!

@engcom-Dash
Copy link
Contributor

Hello @sydor-dev,

As per your request this pull request is being reopened. Please proceed with the necessary updates or changes.

Thank You!

@engcom-Dash engcom-Dash reopened this May 26, 2025
@engcom-Dash engcom-Dash moved this to Changes Requested in Community Dashboard May 26, 2025
@sydor-dev
Copy link
Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

Assignees

@engcom-Dash engcom-Dash

Labels
Partner: Perspective partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Changes Requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] #39604 Fixed rendering products list after applying filters
6 participants
@sydor-dev @engcom-Hotel @rostilos @engcom-Dash @engcom-Charlie @m2-github-services