Skip to content

[Issue] Fix SQL error throwed when websiteId is NULL #37284

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #36802: Fix SQL error throwed when websiteId is NULL


Description (*)

In code is sometimes situation when $websiteId passed to addWebsiteGroupDateFilter is NULL.

Throwed error in GraphQL

image

Code

Problematic part:
image

Inside addWebsiteGroupDateFilter is called $this->addWebsiteFilter($websiteId);, but NULL for $websiteId is not problem there, because inside this method is this variable casted to int.
image

Manual testing scenarios (*)

  1. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Issue: Cannot ReproduceCannot reproduce the issue on the latest `2.4-develop` branchIssue: needs updateAdditional information is require, waiting for responsePriority: P1Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.Progress: doneTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions