Skip to content

Fixed phpdoc block for setUseConfigMinSaleQty, it takes a boolean, not an int #36827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fixed phpdoc block for setUseConfigMinSaleQty, it takes a boolean, not an int #36827

wants to merge 2 commits into from

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Feb 9, 2023

Description (*)

See #36812
To review, check the first commit only, the second commit contains a bunch of fixes for static test failures.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes PHPdoc of setUseConfigMinSaleQty method uses int instead of bool #36812

Manual testing scenarios (*)

See #36812

Questions or comments

I've fixed some static test failures, but not all of them, there are still a bunch needed for Missing short description (Magento2.Annotation.MethodAnnotationStructure.MethodAnnotation) on almost all methods in those classes.
This is out of scope of this PR.
If somebody wants to tackle this, feel free to do so! 🙂

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2023

Hi @hostep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@hostep
Copy link
Contributor Author

hostep commented Feb 9, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Feb 9, 2023
@gustavoulyssea
Copy link

I understand dev's good intentions, but I think this PR is out of scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHPdoc of setUseConfigMinSaleQty method uses int instead of bool
2 participants
@hostep @gustavoulyssea