Skip to content

Internal Server Error in /V1/order/{orderId}/ship API Endpoint #38282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: 2.4-develop
Choose a base branch
from
Open

Internal Server Error in /V1/order/{orderId}/ship API Endpoint #38282

wants to merge 7 commits into from

Conversation

rogerdz
Copy link
Contributor

@rogerdz rogerdz commented Dec 13, 2023

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Internal Server Error in /V1/order/{orderId}/ship API Endpoint #35931

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Dec 13, 2023

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Dec 13, 2023
@rogerdz
Copy link
Contributor Author

rogerdz commented Dec 13, 2023

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel
Copy link
Contributor

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rogerdz,

Thanks for the contribution!

Please look into the failed tests it seems multiple tests are failing due to this change.

Thanks

@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jun 10, 2025
@engcom-Hotel engcom-Hotel moved this from Pending Review to Changes Requested in Pull Requests Dashboard Jun 10, 2025
@rogerdz
Copy link
Contributor Author

rogerdz commented Jun 10, 2025

@magento run all tests

@rogerdz
Copy link
Contributor Author

rogerdz commented Jun 10, 2025

@magento run all tests

@rogerdz
Copy link
Contributor Author

rogerdz commented Jun 11, 2025

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Progress: pending review
Projects
Pull Requests Dashboard
Status: Changes Requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal Server Error in /V1/order/{orderId}/ship API Endpoint
2 participants
@rogerdz @engcom-Hotel