Skip to content

[Setup]Add table prefix to read table on schema builder #33322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[Setup]Add table prefix to read table on schema builder #33322

wants to merge 9 commits into from

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Jun 23, 2021 •
edited
Loading

Description (*)

Prepare list of tables based on table prefix from config. It prevent issue with multiple magento installations into one database.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Cannot run "php bin/magento setup:upgrade" command when 2 stores with different table prefixes are installed in one database. #33320

Manual testing scenarios (*)

See #33320

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 23, 2021

Hi @Den4ik. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@Den4ik Den4ik marked this pull request as ready for review June 23, 2021 13:16
@Den4ik
Copy link
Contributor Author

Den4ik commented Jun 23, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor Author

Den4ik commented Jun 23, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor Author

Den4ik commented Jun 23, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor Author

Den4ik commented Jun 23, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev self-assigned this Jun 24, 2021
@ihor-sviziev ihor-sviziev added Award: bug fix Award: test coverage Progress: pending review Severity: S1 Affects critical data or functionality and forces users to employ a workaround. and removed Progress: review labels Jun 24, 2021
@ihor-sviziev ihor-sviziev added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 24, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev
ihor-sviziev approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests look not related to changes from this PR.

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-9129 has been created to process this Pull Request

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik added 2 commits August 8, 2022 23:13
@Den4ik
Merge remote branch origin/2.4-develop into 33320-add-prefix-to-read-…
b1a4c17 
…tables

Signed-off-by: Denis Kopylov <dkopylov@magenius.team>
@Den4ik
Merge branch '33320-add-prefix-to-read-tables' of github.com:Den4ik/m…
2849367 
…agento2 into 33320-add-prefix-to-read-tables
@Den4ik
Copy link
Contributor Author

Den4ik commented Aug 8, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev removed their assignment Aug 9, 2022
@eduard13 eduard13 removed their assignment Aug 9, 2022
@engcom-Lima engcom-Lima self-assigned this Jul 28, 2023
@engcom-Lima
Copy link
Contributor

Hi @Den4ik ,

Thanks for your contribution and collaboration.

There are conflicts in the file, please resolve the conflicts. Kindly test this in the latest 2.4-develop branch if you are facing any issues please inform us. Moving this to the Changes Requested.

Thanks

@engcom-Lima
Copy link
Contributor

Hi @Den4ik ,

Kindly do the needful.

Thanks

@Den4ik
Copy link
Contributor Author

Den4ik commented Aug 31, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@Den4ik
Copy link
Contributor Author

Den4ik commented Aug 31, 2023

@engcom-Lima Conflict is resolved. You may continue with processing of PR

@engcom-Lima
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@Den4ik
Copy link
Contributor Author

Den4ik commented Nov 4, 2023

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Oct 23, 2024 •
edited
Loading

Hello @Den4ik,

Thank you for your contributions!

Please resolve the conflict so we can proceed with this PR.

Thanks again!

@engcom-Dash
Copy link
Contributor

Closing this PR since it has not been updated in a while. Please feel free to reopen if needed.

@engcom-Dash engcom-Dash closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredden fredden fredden approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@eduard13 eduard13 eduard13 approved these changes

Assignees

@fredden fredden

@engcom-Lima engcom-Lima

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Setup Priority: P3 May be fixed according to the position in the backlog. Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run "php bin/magento setup:upgrade" command when 2 stores with different table prefixes are installed in one database.
8 participants
@Den4ik @ihor-sviziev @magento-engcom-team @engcom-Lima @engcom-Dash @fredden @eduard13 @sdzhepa