Skip to content

Fixed issue #27039: Sales emails asynchronous sending sends out old emails #33366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fixed issue #27039: Sales emails asynchronous sending sends out old emails #33366

wants to merge 3 commits into from

Conversation

GDauer
Copy link
Contributor

@GDauer GDauer commented Jun 27, 2021

Description (*)

Fixed filter for async email sending and refactoring the class as well.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Sales emails asynchronous sending sends out old emails #27039

Manual testing scenarios (*)

  1. Create new Orders
  2. Enable the email async sending
  3. Check if it only sends emails for Orders created one day before the new configuration has been enabled.

Questions or comments

The bugfix itself is only the change in the condition for created_at in the collection filter.

From:
$collection->addFieldToFilter('created_at', ['from' => $startFromDate]);

To:
$collection->addFieldToFilter('created_at', ['gteq' => $startFromDate]);

All others changes is related to the refactoring of the class.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2021

Hi @GDauer. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Progress: pending review labels Jun 27, 2021
@GDauer
Copy link
Contributor Author

GDauer commented Jun 27, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@GDauer
Copy link
Contributor Author

GDauer commented Jun 28, 2021

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests, Sample Data Tests B2B, Sample Data Tests EE, Static Tests, Unit Tests, WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@GDauer
Copy link
Contributor Author

GDauer commented Jun 28, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik Den4ik self-assigned this Jun 29, 2021
@Den4ik Den4ik self-requested a review June 29, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Awaiting requested review from Den4ik

Assignees

@Den4ik Den4ik

Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sales emails asynchronous sending sends out old emails
2 participants
@GDauer @Den4ik