Merge branch '2.3-develop' of https://github.com/mattijv/magento2 into 2.3-develop

Author: mattijv

lib/internal/Magento/Framework/App/PageCache/Kernel.php

@@ -137,7 +137,9 @@ public function process(\Magento\Framework\App\Response\Http $response)
         if (preg_match('/public.*s-maxage=(\d+)/', $response->getHeader('Cache-Control')->getFieldValue(), $matches)) {
             $maxAge = $matches[1];
             $response->setNoCacheHeaders();
-            if ($this->shouldCacheResponse($response)) {
+            if (($response->getHttpResponseCode() == 200 || $response->getHttpResponseCode() == 404)
+                && ($this->request->isGet() || $this->request->isHead())
+            ) {
                 $tagsHeader = $response->getHeader('X-Magento-Tags');
                 $tags = $tagsHeader ? explode(',', $tagsHeader->getFieldValue()) : [];
 
@@ -216,22 +218,4 @@ private function getCache()
         }
         return $this->fullPageCache;
     }
-
-    /**
-     * Check if the response should be cached. For GET requests both 200 and 404 responses should be
-     * cached. For HEAD requests only 200 responses should be cached.
-     *
-     * @param \Magento\Framework\App\Response\Http $response
-     * @return bool
-     */
-    private function shouldCacheResponse(\Magento\Framework\App\Response\Http $response)
-    {
-        $responseCode = $response->getHttpResponseCode();
-        if ($this->request->isGet()) {
-            return $responseCode == 200 || $responseCode == 404;
-        } elseif ($this->request->isHead()) {
-            return $responseCode == 200;
-        }
-        return false;
-    }
 }

lib/internal/Magento/Framework/App/Test/Unit/PageCache/KernelTest.php

@@ -248,7 +248,7 @@ public function testProcessSaveCacheDataProvider()
     {
         return [
             [200, [3, 4, 5]],
-            [404, [3, 4, 5]]
+            [404, [4, 5, 6]]
         ];
     }