Skip to content

Commit ccf646d

Browse files
🔃 [EngCom] Public Pull Requests - 2.2-develop
Accepted Public Pull Requests: - #14599: Specify the table when adding field to filter (by @PierreLeMaguer) - #14552: Allow to configure min and max dates for date picker component (by @tkotosz) - #14559: Fix for Issue #13950 - Cache issue with configurable products related to currency-conversions (by @nuzil) Fixed GitHub Issues: - #14572: Specify the table when adding field to filter for the collection Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php (reported by @PierreLeMaguer) has been fixed in #14599 by @PierreLeMaguer in 2.2-develop branch Related commits: 1. 215c783
2 parents 17f9341 + 566a48c commit ccf646d

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

app/code/Magento/CatalogWidget/Block/Product/ProductsList.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ public function getCacheKeyInfo()
160160

161161
return [
162162
'CATALOG_PRODUCTS_LIST_WIDGET',
163-
$this->getPriceCurrency()->getCurrencySymbol(),
163+
$this->getPriceCurrency()->getCurrency()->getCode(),
164164
$this->_storeManager->getStore()->getId(),
165165
$this->_design->getDesignTheme()->getId(),
166166
$this->httpContext->getValue(\Magento\Customer\Model\Context::CONTEXT_GROUP),

app/code/Magento/CatalogWidget/Test/Unit/Block/Product/ProductsListTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,9 @@ public function testGetCacheKeyInfo()
147147
$this->request->expects($this->once())->method('getParam')->with('page_number')->willReturn(1);
148148

149149
$this->request->expects($this->once())->method('getParams')->willReturn('request_params');
150-
$this->priceCurrency->expects($this->once())->method('getCurrencySymbol')->willReturn('$');
150+
$currency = $this->createMock(\Magento\Directory\Model\Currency::class);
151+
$currency->expects($this->once())->method('getCode')->willReturn('USD');
152+
$this->priceCurrency->expects($this->once())->method('getCurrency')->willReturn($currency);
151153

152154
$this->serializer->expects($this->any())
153155
->method('serialize')
@@ -157,7 +159,7 @@ public function testGetCacheKeyInfo()
157159

158160
$cacheKey = [
159161
'CATALOG_PRODUCTS_LIST_WIDGET',
160-
'$',
162+
'USD',
161163
1,
162164
'blank',
163165
'context_group',

app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ protected function _construct()
7878
*/
7979
public function setAttributeFilter($setId)
8080
{
81-
return $this->addFieldToFilter('attribute_id', $setId);
81+
return $this->addFieldToFilter('main_table.attribute_id', $setId);
8282
}
8383

8484
/**

lib/internal/Magento/Framework/Data/Form/Element/Date.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@ public function getElementHtml()
167167
'buttonImage' => $this->getImage(),
168168
'buttonText' => 'Select Date',
169169
'disabled' => $this->getDisabled(),
170+
'minDate' => $this->getMinDate(),
171+
'maxDate' => $this->getMaxDate(),
170172
],
171173
]
172174
)

0 commit comments

Comments
 (0)