Skip to content

Commit c9d1397

Browse files
authored
Merge pull request #8092 from magento-gl/comm_78764_36529
[Bluetooth] Community Pull Requests delivery - 2.4-develop
2 parents 6de2066 + 826975f commit c9d1397

File tree

7 files changed

+20
-10
lines changed

7 files changed

+20
-10
lines changed

app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/ExtractDataFromCategoryTree.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ private function sortTree(array &$tree): array
7070
} elseif (isset($node['children_count'])) {
7171
$node['children_count'] = 0;
7272
}
73+
// redirect_code null will not return , so it will be 0 when there is no redirect error.
74+
if (!isset($node['redirect_code'])) {
75+
$node['redirect_code'] = 0;
76+
}
7377
}
7478

7579
return $tree;

app/code/Magento/ConfigurableProduct/Model/Plugin/ProductIdentitiesExtender.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
namespace Magento\ConfigurableProduct\Model\Plugin;
99

10+
use Magento\Catalog\Model\Product\Type as ProductTypes;
1011
use Magento\ConfigurableProduct\Model\Product\Type\Configurable as ConfigurableType;
1112
use Magento\Catalog\Api\ProductRepositoryInterface;
1213
use Magento\Catalog\Model\Product;
@@ -51,7 +52,7 @@ public function __construct(ConfigurableType $configurableType, ProductRepositor
5152
*/
5253
public function afterGetIdentities(Product $subject, array $identities): array
5354
{
54-
if ($subject->getTypeId() !== ConfigurableType::TYPE_CODE) {
55+
if ($subject->getTypeId() !== ProductTypes::TYPE_SIMPLE) {
5556
return $identities;
5657
}
5758
$parentProductsIdentities = [];

app/code/Magento/ConfigurableProduct/Test/Unit/Model/Plugin/ProductIdentitiesExtenderTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
use Magento\Catalog\Api\ProductRepositoryInterface;
1111
use Magento\Catalog\Model\Product;
12+
use Magento\Catalog\Model\Product\Type;
1213
use Magento\ConfigurableProduct\Model\Plugin\ProductIdentitiesExtender;
1314
use Magento\ConfigurableProduct\Model\Product\Type\Configurable;
1415
use PHPUnit\Framework\MockObject\MockObject;
@@ -71,7 +72,7 @@ public function testAfterGetIdentities()
7172
->willReturn($productId);
7273
$productMock->expects($this->exactly(2))
7374
->method('getTypeId')
74-
->willReturn(Configurable::TYPE_CODE);
75+
->willReturn(Type::TYPE_SIMPLE);
7576
$this->configurableTypeMock->expects($this->once())
7677
->method('getParentIdsByChild')
7778
->with($productId)

app/code/Magento/Customer/Test/Unit/Ui/Component/Listing/ColumnsTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ public function testPrepareWithAddColumn(): void
160160
public function testPrepareWithUpdateColumn(): void
161161
{
162162
$attributeCode = 'billing_attribute_code';
163-
$backendType = 'backend-type';
163+
$frontendInput = 'text';
164164
$attributeData = [
165165
'attribute_code' => 'billing_attribute_code',
166166
'frontend_input' => 'text',
@@ -211,7 +211,7 @@ public function testPrepareWithUpdateColumn(): void
211211
'config',
212212
[
213213
'name' => $attributeCode,
214-
'dataType' => $backendType,
214+
'dataType' => $frontendInput,
215215
'filter' => [
216216
'filterType' => 'text',
217217
'conditionType' => 'like',

app/code/Magento/Customer/Ui/Component/Listing/Columns.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ public function updateColumn(array $attributeData, $newAttributeCode)
171171
$component->getData('config'),
172172
[
173173
'name' => $newAttributeCode,
174-
'dataType' => $attributeData[AttributeMetadata::BACKEND_TYPE],
174+
'dataType' => $attributeData[AttributeMetadata::FRONTEND_INPUT],
175175
'visible' => (bool)$attributeData[AttributeMetadata::IS_VISIBLE_IN_GRID]
176176
]
177177
);

dev/tests/integration/framework/Magento/TestFramework/Application.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ public function cleanup()
525525
* @see \Magento\Setup\Mvc\Bootstrap\InitParamListener::BOOTSTRAP_PARAM
526526
*/
527527
$this->_shell->execute(
528-
PHP_BINARY . ' -f %s setup:uninstall -vvv -n --magento-init-params=%s',
528+
PHP_BINARY . ' -f %s setup:uninstall --no-interaction -vvv -n --magento-init-params=%s',
529529
[BP . '/bin/magento', $this->getInitParamsQuery()]
530530
);
531531
}
@@ -551,6 +551,7 @@ public function install($cleanup)
551551
$this->copyGlobalConfigFile();
552552

553553
$installParams = $this->getInstallCliParams();
554+
$installParams['--no-interaction'] = true;
554555

555556
// performance optimization: restore DB from last good dump to make installation on top of it (much faster)
556557
// do not restore from the database if the cleanup option is set to ensure we have a clean DB to test on
@@ -609,7 +610,9 @@ protected function runPostInstallCommands()
609610
$command = $postInstallSetupCommand['command'];
610611
$argumentsAndOptions = $postInstallSetupCommand['config'];
611612

612-
$argumentsAndOptionsPlaceholders = [];
613+
$argumentsAndOptionsPlaceholders = [
614+
'--no-interaction'
615+
];
613616

614617
foreach (array_keys($argumentsAndOptions) as $key) {
615618
$isArgument = is_numeric($key);

dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ public function installDataProvider()
183183
$installShellCommandExpectation = [
184184
PHP_BINARY . ' -f %s setup:install -vvv ' .
185185
'--db-host=%s --db-user=%s --db-password=%s --db-name=%s --db-prefix=%s ' .
186-
'--use-secure=%s --use-secure-admin=%s --magento-init-params=%s',
186+
'--use-secure=%s --use-secure-admin=%s --magento-init-params=%s --no-interaction',
187187
[
188188
BP . '/bin/magento',
189189
'/tmp/mysql.sock',
@@ -194,6 +194,7 @@ public function installDataProvider()
194194
'0',
195195
'0',
196196
$this->getInitParamsQuery(sys_get_temp_dir()),
197+
true
197198
]
198199
];
199200

@@ -213,7 +214,7 @@ public function installDataProvider()
213214
[
214215
$installShellCommandExpectation,
215216
[
216-
PHP_BINARY . ' -f %s %s -vvv ' .
217+
PHP_BINARY . ' -f %s %s -vvv --no-interaction ' .
217218
'--host=%s --dbname=%s --username=%s --password=%s --magento-init-params=%s',
218219
[
219220
BP . '/bin/magento',
@@ -234,7 +235,7 @@ public function installDataProvider()
234235
[
235236
$installShellCommandExpectation,
236237
[
237-
PHP_BINARY . ' -f %s %s -vvv %s %s --option1=%s -option2=%s --magento-init-params=%s',
238+
PHP_BINARY . ' -f %s %s -vvv --no-interaction %s %s --option1=%s -option2=%s --magento-init-params=%s', // phpcs:ignore
238239
[
239240
BP . '/bin/magento',
240241
'fake:command',

0 commit comments

Comments
 (0)