Skip to content

Commit c8b7223

Browse files
committed
2.0.0.0-dev87
* Service layer updates: * Created Tax Calculation service * Implemented search Tax Rates(search criteria) in TaxRate service * Refactored Tax Helper to use Tax Service * Validated and ensured that after helper fix, all modules with cross-dependencies use Tax Services * Refactored Bundle, Catalog, Checkout, Customer, Downloadable, Review, Logging Modules to use Tax Services * Refactored Internal Tax Module Blocks/Templates to use Tax Services * GitHub requests: * [#579] (#579) -- update GA code from ga.js to analytics.js * [#584] (#584) -- Merge and minify js - Exception * [#585] (#585) -- Add forgotten return statement * [#592] (#592) -- Module name pattern * Tax calculation updates: * Separate and display Weee line item totals from Tax * Fixed bugs: * Fixed an issue when Custom attribute template was not applied to a product during product creation * Fixed an issue when report grid with no results contained unnecessary empty "total" section * Fixed an issue where MCRYPT_RIJNDAEL_128 Cipher was set instead of 256 version * Fixed an issue when inline translate script was always included in the page even if it was not used * Fixed an issue where URL Generation was affected by previously processed URLs * Fixed an issue with cross-site scripting vulnerability via cookie exploitation * Fixed an issue with incorrect success message after system variable was deleted * Fixed an issue with category page not opening if it had bundle product with fixed price assigned to it * Fixed an issue when subtotal price in a shopping cart was not updated if the product qty is changed * Fixed an issue when syntax error appeared while creating new Google Content attribute mapping * Fixed an issue with JS error when adding associated simple product to the grouped one * Fixed an issue with incorrect items label for the cases when there are more than one item in the category * Fixed an issue when configurable product was out of stock in Google Shopping while being in stock in the Magento backend * Fixed an issue when swipe gesture in menu widget was not supported on mobile * Fixed an issue when it was impossible to enter alpha-numeric zip code on the stage of estimating shipping and tax rates * Fixed an issue when it was impossible to edit gift card account * Fixed an issue when custom price was not applied when editing an order * Fixed an issue when items were not returned to stock after unsuccessful order was placed * Fixed an issue when error message appeared "Cannot save the credit memo while creating credit memo * Fixed an issue when Catalog price rule was not shown for the product if price was less than a discount * Indexer implementation: * Implemented a new Stock indexer * Implemented a new EAV indexer * Fixed failed L1 plan on phpunit 4.1.0 * Minor updates for integration test framework * Split action controllers classes into action classes * Added public MTF repository to the packagist.org * Added the following functional tests: * Create Admin User * Create Category * Create Custom Url Rewrite * Create Frontend Product Review * Delete CMS Page * Delete Product * Delete System Variable * Update Admin User Role * Update Product Review * Indexer-less implementation of URL Rewrites functionality in new UrlRedirect module: * Ported Admin UI from old UrlRewrite module * Implemented URL Rewrites unified storage * Covered the following Magento application components with unit tests: * `Magento/Bundle/Block/Sales/Order/Items/Renderer.php` * `Magento/Bundle/Helper/Catalog/Product/Configuration.php` * `Magento/Bundle/Helper/Data.php` * `Magento/Bundle/Model/Option.php` * `Magento/Bundle/Model/Plugin/PriceBackend.php` * `Magento/Bundle/Model/Product/Attribute/Source/Price/View.php` * `Magento/Bundle/Model/Sales/Order/Pdf/Items/AbstractItems.php` * `Magento/Catalog/Model/Product/Attribute/Source/Msrp/Type/Enabled.php` * `Magento/Catalog/Model/Product/Attribute/Source/Msrp/Type/Price.php` * `Magento/Catalog/Model/Product/Visibility.php` * `Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php` * `Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php` * `Magento/Eav/Model/Entity/Attribute/Source/Boolean.php` * `Magento/Eav/Model/Entity/Attribute/Source/Table.php` * `Magento/Tax/Model/TaxClass/Source/Product.php` * Covered Magento library with unit tests : * `lib/internal/Magento/Framework/Simplexml/Config/Cache/AbstractCache.php` * `lib/internal/Magento/Framework/Simplexml/Config.php` * `lib/internal/Magento/Framework/Stdlib/DateTime/DateTime.php` * `lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php` * `lib/internal/Magento/Framework/Stdlib/String.php`
1 parent f19b465 commit c8b7223

File tree

2,175 files changed

+98525
-47417
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,175 files changed

+98525
-47417
lines changed

CHANGELOG.md

Lines changed: 85 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,83 @@
1+
2.0.0.0-dev87
2+
=============
3+
* Service layer updates:
4+
* Created Tax Calculation service
5+
* Implemented search Tax Rates(search criteria) in TaxRate service
6+
* Refactored Tax Helper to use Tax Service
7+
* Validated and ensured that after helper fix, all modules with cross-dependencies use Tax Services
8+
* Refactored Bundle, Catalog, Checkout, Customer, Downloadable, Review, Logging Modules to use Tax Services
9+
* Refactored Internal Tax Module Blocks/Templates to use Tax Services
10+
* GitHub requests:
11+
* [#579] (https://github.com/magento/magento2/pull/579) -- update GA code from ga.js to analytics.js
12+
* [#584] (https://github.com/magento/magento2/issues/584) -- Merge and minify js - Exception
13+
* [#585] (https://github.com/magento/magento2/pull/585) -- Add forgotten return statement
14+
* [#592] (https://github.com/magento/magento2/issues/592) -- Module name pattern
15+
* Tax calculation updates:
16+
* Separate and display Weee line item totals from Tax
17+
* Fixed bugs:
18+
* Fixed an issue when Custom attribute template was not applied to a product during product creation
19+
* Fixed an issue when report grid with no results contained unnecessary empty "total" section
20+
* Fixed an issue where MCRYPT_RIJNDAEL_128 Cipher was set instead of 256 version
21+
* Fixed an issue when inline translate script was always included in the page even if it was not used
22+
* Fixed an issue where URL Generation was affected by previously processed URLs
23+
* Fixed an issue with cross-site scripting vulnerability via cookie exploitation
24+
* Fixed an issue with incorrect success message after system variable was deleted
25+
* Fixed an issue with category page not opening if it had bundle product with fixed price assigned to it
26+
* Fixed an issue when subtotal price in a shopping cart was not updated if the product qty is changed
27+
* Fixed an issue when syntax error appeared while creating new Google Content attribute mapping
28+
* Fixed an issue with JS error when adding associated simple product to the grouped one
29+
* Fixed an issue with incorrect items label for the cases when there are more than one item in the category
30+
* Fixed an issue when configurable product was out of stock in Google Shopping while being in stock in the Magento backend
31+
* Fixed an issue when swipe gesture in menu widget was not supported on mobile
32+
* Fixed an issue when it was impossible to enter alpha-numeric zip code on the stage of estimating shipping and tax rates
33+
* Fixed an issue when it was impossible to edit gift card account
34+
* Fixed an issue when custom price was not applied when editing an order
35+
* Fixed an issue when items were not returned to stock after unsuccessful order was placed
36+
* Fixed an issue when error message appeared "Cannot save the credit memo” while creating credit memo
37+
* Fixed an issue when Catalog price rule was not shown for the product if price was less than a discount
38+
* Indexer implementation:
39+
* Implemented a new Stock indexer
40+
* Implemented a new EAV indexer
41+
* Fixed failed L1 plan on phpunit 4.1.0
42+
* Minor updates for integration test framework
43+
* Split action controllers classes into action classes
44+
* Added public MTF repository to the packagist.org
45+
* Added the following functional tests:
46+
* Create Admin User
47+
* Create Category
48+
* Create Custom Url Rewrite
49+
* Create Frontend Product Review
50+
* Delete CMS Page
51+
* Delete Product
52+
* Delete System Variable
53+
* Update Admin User Role
54+
* Update Product Review
55+
* Indexer-less implementation of URL Rewrites functionality in new UrlRedirect module:
56+
* Ported Admin UI from old UrlRewrite module
57+
* Implemented URL Rewrites unified storage
58+
* Covered the following Magento application components with unit tests:
59+
* `Magento/Bundle/Block/Sales/Order/Items/Renderer.php`
60+
* `Magento/Bundle/Helper/Catalog/Product/Configuration.php`
61+
* `Magento/Bundle/Helper/Data.php`
62+
* `Magento/Bundle/Model/Option.php`
63+
* `Magento/Bundle/Model/Plugin/PriceBackend.php`
64+
* `Magento/Bundle/Model/Product/Attribute/Source/Price/View.php`
65+
* `Magento/Bundle/Model/Sales/Order/Pdf/Items/AbstractItems.php`
66+
* `Magento/Catalog/Model/Product/Attribute/Source/Msrp/Type/Enabled.php`
67+
* `Magento/Catalog/Model/Product/Attribute/Source/Msrp/Type/Price.php`
68+
* `Magento/Catalog/Model/Product/Visibility.php`
69+
* `Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php`
70+
* `Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php`
71+
* `Magento/Eav/Model/Entity/Attribute/Source/Boolean.php`
72+
* `Magento/Eav/Model/Entity/Attribute/Source/Table.php`
73+
* `Magento/Tax/Model/TaxClass/Source/Product.php`
74+
* Covered Magento library with unit tests :
75+
* `lib/internal/Magento/Framework/Simplexml/Config/Cache/AbstractCache.php`
76+
* `lib/internal/Magento/Framework/Simplexml/Config.php`
77+
* `lib/internal/Magento/Framework/Stdlib/DateTime/DateTime.php`
78+
* `lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php`
79+
* `lib/internal/Magento/Framework/Stdlib/String.php`
80+
181
2.0.0.0-dev86
282
=============
383
* Service layer updates:
@@ -46,8 +126,8 @@
46126
* Fixed issues with the translate and the logging transformation tools
47127
* Fixed an issue where it was impossible to create a URL rewrite for a CMS Page with Temporary (302) or Permanent (301) redirect
48128
* GitHub requests:
49-
* [#598] Add Sort Order to Rules
50-
* [#580] Set changed status on model to prevent status overwriting when model gets saved
129+
* [#598] (https://github.com/magento/magento2/pull/598) -- Add Sort Order to Rules
130+
* [#580] (https://github.com/magento/magento2/pull/580) -- Set changed status on model to prevent status overwriting when model gets saved
51131
* Unit Tests Coverage:
52132
* Part of the Catalog module covered with the unit tests
53133
* Added the following functional tests:
@@ -81,7 +161,7 @@
81161
* Created ProductsCustomOptions Service API for Catalog module
82162
* Created DownloadableLink Service API for Catalog module
83163
* GitHub requests:
84-
* [#257] JSON loading should follow OWASP recommendation
164+
* [#257] (https://github.com/magento/magento2/issues/257) -- JSON loading should follow OWASP recommendation
85165

86166
2.0.0.0-dev84
87167
=============
@@ -102,8 +182,8 @@
102182
* Fixed an issue where an admin could search product by attributes set on the Store View level (except default store view)
103183
* Fixed an issue where extra spaces in search values were not ignored during search and thus wrong search results were given
104184
* GitHub requests:
105-
* [#542] Fix ImportExport bug which occurs while importing multiple rows per entity
106-
* [#544] Performance tests not working
185+
* [#542] (https://github.com/magento/magento2/pull/542) -- Fix ImportExport bug which occurs while importing multiple rows per entity
186+
* [#544] (https://github.com/magento/magento2/issues/544) -- Performance tests not working
107187
* Framework improvements:
108188
* Covered the following Magento application components with unit tests:
109189
* `Customer/Model/Address.php`

app/code/Magento/AdminNotification/Block/Inbox.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@ protected function _construct()
3636
$this->_blockGroup = 'Magento_AdminNotification';
3737
$this->_headerText = __('Messages Inbox');
3838
parent::_construct();
39-
$this->_removeButton('add');
39+
$this->buttonList->remove('add');
4040
}
4141
}

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification.php

Lines changed: 0 additions & 157 deletions
Original file line numberDiff line numberDiff line change
@@ -27,163 +27,6 @@
2727

2828
class Notification extends \Magento\Backend\App\AbstractAction
2929
{
30-
/**
31-
* @return void
32-
*/
33-
public function indexAction()
34-
{
35-
$this->_title->add(__('Notifications'));
36-
37-
$this->_view->loadLayout();
38-
$this->_setActiveMenu(
39-
'Magento_AdminNotification::system_adminnotification'
40-
)->_addBreadcrumb(
41-
__('Messages Inbox'),
42-
__('Messages Inbox')
43-
);
44-
$this->_view->renderLayout();
45-
}
46-
47-
/**
48-
* @return void
49-
*/
50-
public function markAsReadAction()
51-
{
52-
$notificationId = (int)$this->getRequest()->getParam('id');
53-
if ($notificationId) {
54-
try {
55-
$this->_objectManager->create(
56-
'Magento\AdminNotification\Model\NotificationService'
57-
)->markAsRead(
58-
$notificationId
59-
);
60-
$this->messageManager->addSuccess(__('The message has been marked as Read.'));
61-
} catch (\Magento\Framework\Model\Exception $e) {
62-
$this->messageManager->addError($e->getMessage());
63-
} catch (\Exception $e) {
64-
$this->messageManager->addException(
65-
$e,
66-
__("We couldn't mark the notification as Read because of an error.")
67-
);
68-
}
69-
70-
$this->getResponse()->setRedirect($this->_redirect->getRedirectUrl($this->getUrl('*')));
71-
return;
72-
}
73-
$this->_redirect('adminhtml/*/');
74-
}
75-
76-
/**
77-
* Mark notification as read (AJAX action)
78-
*
79-
* @return void
80-
*/
81-
public function ajaxMarkAsReadAction()
82-
{
83-
if (!$this->getRequest()->getPost()) {
84-
return;
85-
}
86-
$notificationId = (int)$this->getRequest()->getPost('id');
87-
$responseData = array();
88-
try {
89-
$this->_objectManager->create(
90-
'Magento\AdminNotification\Model\NotificationService'
91-
)->markAsRead(
92-
$notificationId
93-
);
94-
$responseData['success'] = true;
95-
} catch (\Exception $e) {
96-
$responseData['success'] = false;
97-
}
98-
$this->getResponse()->representJson(
99-
$this->_objectManager->create('Magento\Core\Helper\Data')->jsonEncode($responseData)
100-
);
101-
}
102-
103-
/**
104-
* @return void
105-
*/
106-
public function massMarkAsReadAction()
107-
{
108-
$ids = $this->getRequest()->getParam('notification');
109-
if (!is_array($ids)) {
110-
$this->messageManager->addError(__('Please select messages.'));
111-
} else {
112-
try {
113-
foreach ($ids as $id) {
114-
$model = $this->_objectManager->create('Magento\AdminNotification\Model\Inbox')->load($id);
115-
if ($model->getId()) {
116-
$model->setIsRead(1)->save();
117-
}
118-
}
119-
$this->messageManager->addSuccess(
120-
__('A total of %1 record(s) have been marked as Read.', count($ids))
121-
);
122-
} catch (\Magento\Framework\Model\Exception $e) {
123-
$this->messageManager->addError($e->getMessage());
124-
} catch (\Exception $e) {
125-
$this->messageManager->addException(
126-
$e,
127-
__("We couldn't mark the notification as Read because of an error.")
128-
);
129-
}
130-
}
131-
$this->_redirect('adminhtml/*/');
132-
}
133-
134-
/**
135-
* @return void
136-
*/
137-
public function removeAction()
138-
{
139-
if ($id = $this->getRequest()->getParam('id')) {
140-
$model = $this->_objectManager->create('Magento\AdminNotification\Model\Inbox')->load($id);
141-
142-
if (!$model->getId()) {
143-
$this->_redirect('adminhtml/*/');
144-
return;
145-
}
146-
147-
try {
148-
$model->setIsRemove(1)->save();
149-
$this->messageManager->addSuccess(__('The message has been removed.'));
150-
} catch (\Magento\Framework\Model\Exception $e) {
151-
$this->messageManager->addError($e->getMessage());
152-
} catch (\Exception $e) {
153-
$this->messageManager->addException($e, __("We couldn't remove the messages because of an error."));
154-
}
155-
156-
$this->_redirect('adminhtml/*/');
157-
return;
158-
}
159-
$this->_redirect('adminhtml/*/');
160-
}
161-
162-
/**
163-
* @return void
164-
*/
165-
public function massRemoveAction()
166-
{
167-
$ids = $this->getRequest()->getParam('notification');
168-
if (!is_array($ids)) {
169-
$this->messageManager->addError(__('Please select messages.'));
170-
} else {
171-
try {
172-
foreach ($ids as $id) {
173-
$model = $this->_objectManager->create('Magento\AdminNotification\Model\Inbox')->load($id);
174-
if ($model->getId()) {
175-
$model->setIsRemove(1)->save();
176-
}
177-
}
178-
$this->messageManager->addSuccess(__('Total of %1 record(s) have been removed.', count($ids)));
179-
} catch (\Magento\Framework\Model\Exception $e) {
180-
$this->messageManager->addError($e->getMessage());
181-
} catch (\Exception $e) {
182-
$this->messageManager->addException($e, __("We couldn't remove the messages because of an error."));
183-
}
184-
}
185-
$this->getResponse()->setRedirect($this->_redirect->getRedirectUrl($this->getUrl('*')));
186-
}
18730

18831
/**
18932
* @return bool
Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
<?php
2+
/**
3+
*
4+
* Magento
5+
*
6+
* NOTICE OF LICENSE
7+
*
8+
* This source file is subject to the Open Software License (OSL 3.0)
9+
* that is bundled with this package in the file LICENSE.txt.
10+
* It is also available through the world-wide-web at this URL:
11+
* http://opensource.org/licenses/osl-3.0.php
12+
* If you did not receive a copy of the license and are unable to
13+
* obtain it through the world-wide-web, please send an email
14+
* to license@magentocommerce.com so we can send you a copy immediately.
15+
*
16+
* DISCLAIMER
17+
*
18+
* Do not edit or add to this file if you wish to upgrade Magento to newer
19+
* versions in the future. If you wish to customize Magento for your
20+
* needs please refer to http://www.magentocommerce.com for more information.
21+
*
22+
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
23+
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
24+
*/
25+
namespace Magento\AdminNotification\Controller\Adminhtml\Notification;
26+
27+
class AjaxMarkAsRead extends \Magento\AdminNotification\Controller\Adminhtml\Notification
28+
{
29+
/**
30+
* Mark notification as read (AJAX action)
31+
*
32+
* @return void
33+
*/
34+
public function execute()
35+
{
36+
if (!$this->getRequest()->getPost()) {
37+
return;
38+
}
39+
$notificationId = (int)$this->getRequest()->getPost('id');
40+
$responseData = array();
41+
try {
42+
$this->_objectManager->create(
43+
'Magento\AdminNotification\Model\NotificationService'
44+
)->markAsRead(
45+
$notificationId
46+
);
47+
$responseData['success'] = true;
48+
} catch (\Exception $e) {
49+
$responseData['success'] = false;
50+
}
51+
$this->getResponse()->representJson(
52+
$this->_objectManager->create('Magento\Core\Helper\Data')->jsonEncode($responseData)
53+
);
54+
}
55+
}
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
<?php
2+
/**
3+
*
4+
* Magento
5+
*
6+
* NOTICE OF LICENSE
7+
*
8+
* This source file is subject to the Open Software License (OSL 3.0)
9+
* that is bundled with this package in the file LICENSE.txt.
10+
* It is also available through the world-wide-web at this URL:
11+
* http://opensource.org/licenses/osl-3.0.php
12+
* If you did not receive a copy of the license and are unable to
13+
* obtain it through the world-wide-web, please send an email
14+
* to license@magentocommerce.com so we can send you a copy immediately.
15+
*
16+
* DISCLAIMER
17+
*
18+
* Do not edit or add to this file if you wish to upgrade Magento to newer
19+
* versions in the future. If you wish to customize Magento for your
20+
* needs please refer to http://www.magentocommerce.com for more information.
21+
*
22+
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
23+
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
24+
*/
25+
namespace Magento\AdminNotification\Controller\Adminhtml\Notification;
26+
27+
class Index extends \Magento\AdminNotification\Controller\Adminhtml\Notification
28+
{
29+
/**
30+
* @return void
31+
*/
32+
public function execute()
33+
{
34+
$this->_title->add(__('Notifications'));
35+
36+
$this->_view->loadLayout();
37+
$this->_setActiveMenu(
38+
'Magento_AdminNotification::system_adminnotification'
39+
)->_addBreadcrumb(
40+
__('Messages Inbox'),
41+
__('Messages Inbox')
42+
);
43+
$this->_view->renderLayout();
44+
}
45+
}

0 commit comments

Comments
 (0)