#13580: DB schema consistency fix.

Author: engcom-Foxtrot

setup/src/Magento/Setup/Model/Installer.php

@@ -16,6 +16,7 @@
 use Magento\Framework\Config\ConfigOptionsListConstants;
 use Magento\Framework\Config\Data\ConfigData;
 use Magento\Framework\Config\File\ConfigFilePool;
+use Magento\Framework\DB\Adapter\AdapterInterface;
 use Magento\Framework\DB\Adapter\Pdo\Mysql;
 use Magento\Framework\Exception\FileSystemException;
 use Magento\Framework\Filesystem;
@@ -603,7 +604,7 @@ private function setupModuleRegistry(SchemaSetupInterface $setup)
      */
     private function setupCoreTables(SchemaSetupInterface $setup)
     {
-        /* @var $connection \Magento\Framework\DB\Adapter\AdapterInterface */
+        /* @var $connection AdapterInterface */
         $connection = $setup->getConnection();
         $setup->startSetup();
 
@@ -619,12 +620,12 @@ private function setupCoreTables(SchemaSetupInterface $setup)
      * Create table 'session'
      *
      * @param SchemaSetupInterface $setup
-     * @param \Magento\Framework\DB\Adapter\AdapterInterface $connection
+     * @param AdapterInterface $connection
      * @return void
      */
     private function setupSessionTable(
         SchemaSetupInterface $setup,
-        \Magento\Framework\DB\Adapter\AdapterInterface $connection
+        AdapterInterface $connection
     ) {
         if (!$connection->isTableExists($setup->getTable('session'))) {
             $table = $connection->newTable(
@@ -658,12 +659,12 @@ private function setupSessionTable(
      * Create table 'cache'
      *
      * @param SchemaSetupInterface $setup
-     * @param \Magento\Framework\DB\Adapter\AdapterInterface $connection
+     * @param AdapterInterface $connection
      * @return void
      */
     private function setupCacheTable(
         SchemaSetupInterface $setup,
-        \Magento\Framework\DB\Adapter\AdapterInterface $connection
+        AdapterInterface $connection
     ) {
         if (!$connection->isTableExists($setup->getTable('cache'))) {
             $table = $connection->newTable(
@@ -712,12 +713,12 @@ private function setupCacheTable(
      * Create table 'cache_tag'
      *
      * @param SchemaSetupInterface $setup
-     * @param \Magento\Framework\DB\Adapter\AdapterInterface $connection
+     * @param AdapterInterface $connection
      * @return void
      */
     private function setupCacheTagTable(
         SchemaSetupInterface $setup,
-        \Magento\Framework\DB\Adapter\AdapterInterface $connection
+        AdapterInterface $connection
     ) {
         if (!$connection->isTableExists($setup->getTable('cache_tag'))) {
             $table = $connection->newTable(
@@ -748,12 +749,12 @@ private function setupCacheTagTable(
      * Create table 'flag'
      *
      * @param SchemaSetupInterface $setup
-     * @param \Magento\Framework\DB\Adapter\AdapterInterface $connection
+     * @param AdapterInterface $connection
      * @return void
      */
     private function setupFlagTable(
         SchemaSetupInterface $setup,
-        \Magento\Framework\DB\Adapter\AdapterInterface $connection
+        AdapterInterface $connection
     ) {
         if (!$connection->isTableExists($setup->getTable('flag'))) {
             $table = $connection->newTable(
@@ -795,6 +796,8 @@ private function setupFlagTable(
                 'Flag'
             );
             $connection->createTable($table);
+        } else {
+            $this->updateColumnType($connection, 'flag', 'flag_data', 'mediumtext');
         }
     }
 
@@ -1548,4 +1551,28 @@ function ($value, $key) {
 
         return !empty($adminData);
     }
+
+    /**
+     * Update flag_data column data type to maintain consistency.
+     *
+     * @param AdapterInterface $connection
+     * @param string $tableName
+     * @param string $columnName
+     * @param string $typeName
+     */
+    private function updateColumnType(
+        AdapterInterface $connection,
+        string $tableName,
+        string $columnName,
+        string $typeName
+    ): void {
+        $tableDescription = $connection->describeTable($tableName);
+        if ($tableDescription[$columnName]['DATA_TYPE'] !== $typeName) {
+            $connection->modifyColumn(
+                $tableName,
+                $columnName,
+                $typeName
+            );
+        }
+    }
 }