MAGETWO-85545: 8204: catalog:images:resize = getimagesize(): Read error! #1000

Author: ishakhsuvarov

app/code/Magento/Catalog/Console/Command/ImagesResizeCommand.php

@@ -5,6 +5,9 @@
  */
 namespace Magento\Catalog\Console\Command;
 
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+
 class ImagesResizeCommand extends \Symfony\Component\Console\Command\Command
 {
     /**
@@ -58,10 +61,8 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(
-        \Symfony\Component\Console\Input\InputInterface $input,
-        \Symfony\Component\Console\Output\OutputInterface $output
-    ) {
+    protected function execute(InputInterface $input, OutputInterface $output)
+    {
         $this->appState->setAreaCode(\Magento\Framework\App\Area::AREA_GLOBAL);
 
         /** @var \Magento\Catalog\Model\ResourceModel\Product\Collection $productCollection */
@@ -73,6 +74,7 @@ protected function execute(
             return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
         }
 
+        $errorMessage = '';
         try {
             foreach ($productIds as $productId) {
                 try {
@@ -82,9 +84,13 @@ protected function execute(
                     continue;
                 }
 
-                /** @var \Magento\Catalog\Model\Product\Image\Cache $imageCache */
-                $imageCache = $this->imageCacheFactory->create();
-                $imageCache->generate($product);
+                try {
+                    /** @var \Magento\Catalog\Model\Product\Image\Cache $imageCache */
+                    $imageCache = $this->imageCacheFactory->create();
+                    $imageCache->generate($product);
+                } catch (\Magento\Framework\Exception\RuntimeException $e) {
+                    $errorMessage = $e->getMessage();
+                }
 
                 $output->write(".");
             }
@@ -95,6 +101,12 @@ protected function execute(
         }
 
         $output->write("\n");
-        $output->writeln("<info>Product images resized successfully</info>");
+        $output->writeln("<info>Product images resized successfully.</info>");
+
+        if ($errorMessage !== '') {
+            $output->writeln("<comment>{$errorMessage}</comment>");
+        }
+
+        return 0;
     }
 }

app/code/Magento/Catalog/Model/Product/Image/Cache.php

@@ -10,6 +10,7 @@
 use Magento\Theme\Model\ResourceModel\Theme\Collection as ThemeCollection;
 use Magento\Framework\App\Area;
 use Magento\Framework\View\ConfigInterface;
+use Psr\Log\LoggerInterface;
 
 class Cache
 {
@@ -33,19 +34,29 @@ class Cache
      */
     protected $data = [];
 
+    /**
+     * Logger.
+     *
+     * @var LoggerInterface
+     */
+    private $logger;
+
     /**
      * @param ConfigInterface $viewConfig
      * @param ThemeCollection $themeCollection
      * @param ImageHelper $imageHelper
+     * @param LoggerInterface $logger
      */
     public function __construct(
         ConfigInterface $viewConfig,
         ThemeCollection $themeCollection,
-        ImageHelper $imageHelper
+        ImageHelper $imageHelper,
+        LoggerInterface $logger = null
     ) {
         $this->viewConfig = $viewConfig;
         $this->themeCollection = $themeCollection;
         $this->imageHelper = $imageHelper;
+        $this->logger = $logger ?: \Magento\Framework\App\ObjectManager::getInstance()->get(LoggerInterface::class);
     }
 
     /**
@@ -74,21 +85,37 @@ protected function getData()
     }
 
     /**
-     * Resize product images and save results to image cache
+     * Resize product images and save results to image cache.
      *
      * @param Product $product
+     *
      * @return $this
+     * @throws \Exception
      */
     public function generate(Product $product)
     {
+        $isException = false;
         $galleryImages = $product->getMediaGalleryImages();
         if ($galleryImages) {
             foreach ($galleryImages as $image) {
                 foreach ($this->getData() as $imageData) {
-                    $this->processImageData($product, $imageData, $image->getFile());
+                    try {
+                        $this->processImageData($product, $imageData, $image->getFile());
+                    } catch (\Exception $e) {
+                        $isException = true;
+                        $this->logger->error($e->getMessage());
+                        $this->logger->error(__('The image could not be resized: ') . $image->getPath());
+                    }
                 }
             }
         }
+
+        if ($isException === true) {
+            throw new \Magento\Framework\Exception\RuntimeException(
+                __('Some images could not be resized. See log file for details.')
+            );
+        }
+
         return $this;
     }
 

app/code/Magento/Catalog/Test/Unit/Console/Command/ImagesResizeCommandTest.php

@@ -208,4 +208,44 @@ protected function prepareImageCache()
             ->method('create')
             ->willReturn($this->imageCache);
     }
+
+    public function testExecuteWithExceptionInGenerate()
+    {
+        $productsIds = [1, 2];
+
+        $this->appState->expects($this->once())
+            ->method('setAreaCode')
+            ->with(Area::AREA_GLOBAL)
+            ->willReturnSelf();
+
+        $this->productCollection->expects($this->once())
+            ->method('getAllIds')
+            ->willReturn($productsIds);
+
+        $productMock = $this->getMockBuilder(\Magento\Catalog\Model\Product::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->productRepository->expects($this->at(0))
+            ->method('getById')
+            ->with($productsIds[0])
+            ->willReturn($productMock);
+        $this->productRepository->expects($this->at(1))
+            ->method('getById')
+            ->with($productsIds[1])
+            ->willThrowException(new NoSuchEntityException());
+
+        $this->imageCache->expects($this->exactly(count($productsIds) - 1))
+            ->method('generate')
+            ->with($productMock)
+            ->willThrowException(new \Magento\Framework\Exception\RuntimeException(__('Some text is here.')));
+
+        $commandTester = new CommandTester($this->command);
+        $commandTester->execute([]);
+
+        $this->assertContains(
+            'Some text is here.',
+            $commandTester->getDisplay()
+        );
+    }
 }

app/code/Magento/Catalog/Test/Unit/Model/Product/Image/CacheTest.php

@@ -189,6 +189,58 @@ public function testGenerate()
         $this->model->generate($this->product);
     }
 
+    /**
+     * @expectedException \Magento\Framework\Exception\RuntimeException
+     */
+    public function testGenerateWithException()
+    {
+        $imageFile = 'image.jpg';
+        $imageItem = $this->objectManager->getObject(
+            \Magento\Framework\DataObject::class,
+            [
+                'data' => ['file' => $imageFile]
+            ]
+        );
+        $this->mediaGalleryCollection->expects($this->once())
+            ->method('getIterator')
+            ->willReturn(new \ArrayIterator([$imageItem]));
+
+        $this->product->expects($this->atLeastOnce())
+            ->method('getMediaGalleryImages')
+            ->willReturn($this->mediaGalleryCollection);
+
+        $data = $this->getTestData();
+        $this->config->expects($this->once())
+            ->method('getMediaEntities')
+            ->with('Magento_Catalog')
+            ->willReturn($data);
+
+        $themeMock = $this->getMockBuilder(\Magento\Theme\Model\Theme::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $themeMock->expects($this->exactly(3))
+            ->method('getCode')
+            ->willReturn('Magento\theme');
+
+        $this->themeCollection->expects($this->once())
+            ->method('loadRegisteredThemes')
+            ->willReturn([$themeMock]);
+
+        $this->viewConfig->expects($this->once())
+            ->method('getViewConfig')
+            ->with([
+                'area' => Area::AREA_FRONTEND,
+                'themeModel' => $themeMock,
+            ])
+            ->willReturn($this->config);
+
+        $this->imageHelper->expects($this->exactly(3))
+            ->method('init')
+            ->willThrowException(new \Exception('Some text '));
+
+        $this->model->generate($this->product);
+    }
+
     /**
      * @return array
      */