removed caching subscription status from plugin

Author: engcom-Charlie

app/code/Magento/Newsletter/Model/Plugin/CustomerPlugin.php

@@ -52,11 +52,6 @@ class CustomerPlugin
      */
     private $storeManager;
 
-    /**
-     * @var array
-     */
-    private $customerSubscriber = [];
-
     /**
      * @var SubscriberFactory
      */
@@ -132,7 +127,6 @@ public function afterSave(
             $subscriber = $subscribeStatus
                 ? $this->subscriptionManager->subscribeCustomer((int)$result->getId(), $storeId)
                 : $this->subscriptionManager->unsubscribeCustomer((int)$result->getId(), $storeId);
-            $this->customerSubscriber[(int)$result->getId()] = $subscriber;
         }
         $this->addIsSubscribedExtensionAttribute($result, $subscriber->isSubscribed());
 
@@ -314,11 +308,6 @@ private function deleteSubscriptionsAfterCustomerDelete(CustomerInterface $custo
      */
     private function getSubscriber(CustomerInterface $customer): Subscriber
     {
-        $customerId = (int)$customer->getId();
-        if (isset($this->customerSubscriber[$customerId])) {
-            return $this->customerSubscriber[$customerId];
-        }
-
         /** @var Subscriber $subscriber */
         $subscriber = $this->subscriberFactory->create();
         $websiteId = $this->getCurrentWebsiteId($customer);
@@ -330,7 +319,6 @@ private function getSubscriber(CustomerInterface $customer): Subscriber
         if (!$subscriber->getId()) {
             $subscriber->loadBySubscriberEmail((string)$customer->getEmail(), $websiteId);
         }
-        $this->customerSubscriber[$customerId] = $subscriber;
 
         return $subscriber;
     }

dev/tests/integration/testsuite/Magento/Newsletter/Model/SubscriberTest.php

@@ -136,6 +136,27 @@ public function testUnsubscribeSubscribeByCustomerId(): void
         );
     }
 
+    /**
+     * Test subscribe and verify customer subscription status
+     *
+     * @magentoDataFixture Magento/Customer/_files/customer_sample.php
+     *
+     * @return void
+     */
+    public function testSubscribeAndVerifyCustomerSubscriptionStatus(): void
+    {
+        $customer = $this->customerRepository->getById(1);
+        $subscriptionBefore = $customer->getExtensionAttributes()
+            ->getIsSubscribed();
+        $subscriber = $this->subscriberFactory->create();
+        $subscriber->subscribeCustomerById($customer->getId());
+
+        $customer = $this->customerRepository->getById(1);
+
+        $this->assertFalse($subscriptionBefore);
+        $this->assertTrue($customer->getExtensionAttributes()->getIsSubscribed());
+    }
+
     /**
      * @magentoConfigFixture current_store newsletter/subscription/confirm 1
      *