#27338: Changes for SalesRule/Model/Quote/Discount , for fix if exist Extension Attributes

Author: engcom-Kilo

app/code/Magento/SalesRule/Model/Quote/Discount.php

@@ -8,6 +8,7 @@
 use Magento\Framework\App\ObjectManager;
 use Magento\SalesRule\Api\Data\RuleDiscountInterfaceFactory;
 use Magento\SalesRule\Api\Data\DiscountDataInterfaceFactory;
+use Magento\Quote\Api\Data\AddressExtensionFactory;
 
 /**
  * Discount totals calculation model.
@@ -50,21 +51,28 @@ class Discount extends \Magento\Quote\Model\Quote\Address\Total\AbstractTotal
      */
     private $discountDataInterfaceFactory;
 
+    /**
+     * @var AddressExtensionFactory
+     */
+    private $addressExtensionFactory;
+
     /**
      * @param \Magento\Framework\Event\ManagerInterface $eventManager
      * @param \Magento\Store\Model\StoreManagerInterface $storeManager
      * @param \Magento\SalesRule\Model\Validator $validator
      * @param \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency
      * @param RuleDiscountInterfaceFactory|null $discountInterfaceFactory
      * @param DiscountDataInterfaceFactory|null $discountDataInterfaceFactory
+     * @param AddressExtensionFactory|null $addressExtensionFactory
      */
     public function __construct(
         \Magento\Framework\Event\ManagerInterface $eventManager,
         \Magento\Store\Model\StoreManagerInterface $storeManager,
         \Magento\SalesRule\Model\Validator $validator,
         \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency,
         RuleDiscountInterfaceFactory $discountInterfaceFactory = null,
-        DiscountDataInterfaceFactory $discountDataInterfaceFactory = null
+        DiscountDataInterfaceFactory $discountDataInterfaceFactory = null,
+        AddressExtensionFactory $addressExtensionFactory = null
     ) {
         $this->setCode(self::COLLECTOR_TYPE_CODE);
         $this->eventManager = $eventManager;
@@ -75,6 +83,8 @@ public function __construct(
             ?: ObjectManager::getInstance()->get(RuleDiscountInterfaceFactory::class);
         $this->discountDataInterfaceFactory = $discountDataInterfaceFactory
             ?: ObjectManager::getInstance()->get(DiscountDataInterfaceFactory::class);
+        $this->addressExtensionFactory = $addressExtensionFactory
+            ?: ObjectManager::getInstance()->get(AddressExtensionFactory::class);
     }
 
     /**
@@ -84,6 +94,7 @@ public function __construct(
      * @param \Magento\Quote\Api\Data\ShippingAssignmentInterface $shippingAssignment
      * @param \Magento\Quote\Model\Quote\Address\Total $total
      * @return $this
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
      */
@@ -119,7 +130,20 @@ public function collect(
 
         $address->setDiscountDescription([]);
         $items = $this->calculator->sortItemsByPriority($items, $address);
-        $address->getExtensionAttributes()->setDiscounts([]);
+
+        if (!is_object($address->getExtensionAttributes())) {
+            $addressExtensionAttributes = $address->getExtensionAttributes();
+            $addressExtension = $this->addressExtensionFactory->create();
+
+            foreach ($addressExtensionAttributes as $key => $value) {
+                $addressExtension->setData($key, $value);
+            }
+            $addressExtension->setDiscounts([]);
+            $address->setExtensionAttributes($addressExtension);
+        } else {
+            $address->getExtensionAttributes()->setDiscounts([]);
+        }
+
         $addressDiscountAggregator = [];
 
         /** @var \Magento\Quote\Model\Quote\Item $item */
@@ -300,6 +324,7 @@ private function aggregateDiscountPerRule(
                 }
             }
         }
-            $address->getExtensionAttributes()->setDiscounts(array_values($addressDiscountAggregator));
+
+        $address->getExtensionAttributes()->setDiscounts(array_values($addressDiscountAggregator));
     }
 }