merge magento/2.3-develop into magento-epam/EPAM-PR-83

Author: magento-cicd2

dev/tests/static/testsuite/Magento/Test/Legacy/PhtmlTemplateTest.php

@@ -7,6 +7,8 @@
  */
 namespace Magento\Test\Legacy;
 
+use Magento\Framework\Component\ComponentRegistrar;
+
 /**
  * Static test for phtml template files.
  */
@@ -105,4 +107,84 @@ function ($file) {
             \Magento\Framework\App\Utility\Files::init()->getPhtmlFiles()
         );
     }
+
+    public function testJsComponentsAreProperlyInitializedInDataMageInitAttribute()
+    {
+        $invoker = new \Magento\Framework\App\Utility\AggregateInvoker($this);
+        $invoker(
+            /**
+             * JS components in data-mage-init attributes should be initialized not in php.
+             * JS components should be initialized in templates for them to be properly statically analyzed for bundling.
+             *
+             * @param string $file
+             */
+            function ($file) {
+                $whiteList = $this->getWhiteList();
+                if (!in_array($file, $whiteList, true)
+                    && (strpos($file, '/view/frontend/templates/') !== false
+                    || strpos($file, '/view/base/templates/') !== false)
+                ) {
+                    self::assertNotRegExp(
+                        '/data-mage-init=(?:\'|")(?!\s*{\s*"[^"]+")/',
+                        file_get_contents($file),
+                        'Please do not initialize JS component in php. Do it in template.'
+                    );
+                }
+            },
+            \Magento\Framework\App\Utility\Files::init()->getPhtmlFiles()
+        );
+    }
+
+    /**
+     * @return array
+     */
+    private function getWhiteList()
+    {
+        $whiteListFiles = [];
+        $componentRegistrar = new ComponentRegistrar();
+        foreach ($this->getFilesData('data_mage_init/whitelist.php') as $fileInfo) {
+            $whiteListFiles[] = $componentRegistrar->getPath(ComponentRegistrar::MODULE, $fileInfo[0])
+                . DIRECTORY_SEPARATOR . $fileInfo[1];
+        }
+        return $whiteListFiles;
+    }
+
+    /**
+     * @param string $filePattern
+     * @return array
+     */
+    private function getFilesData($filePattern)
+    {
+        $result = [];
+        foreach (glob(__DIR__ . '/_files/initialize_javascript/' . $filePattern) as $file) {
+            $fileData = include $file;
+            $result = array_merge($result, $fileData);
+        }
+        return $result;
+    }
+
+    public function testJsComponentsAreProperlyInitializedInXMagentoInitAttribute()
+    {
+        $invoker = new \Magento\Framework\App\Utility\AggregateInvoker($this);
+        $invoker(
+            /**
+             * JS components in x-magento-init attributes should be initialized not in php.
+             * JS components should be initialized in templates for them to be properly statically analyzed for bundling.
+             *
+             * @param string $file
+             */
+            function ($file) {
+                if (strpos($file, '/view/frontend/templates/') !== false
+                    || strpos($file, '/view/base/templates/') !== false
+                ) {
+                    self::assertNotRegExp(
+                        '@x-magento-init.>(?!\s*+{\s*"[^"]+"\s*:\s*{\s*"[\w/-]+")@i',
+                        file_get_contents($file),
+                        'Please do not initialize JS component in php. Do it in template.'
+                    );
+                }
+            },
+            \Magento\Framework\App\Utility\Files::init()->getPhtmlFiles()
+        );
+    }
 }

dev/tests/static/testsuite/Magento/Test/Legacy/_files/initialize_javascript/data_mage_init/whitelist.php

@@ -0,0 +1,14 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+/**
+ * List of templates with data-mage-init attribute where JS component is not correctly called.
+ *
+ * JS component is initialized in php here. These templates cannot be refactored easily. This list consists of
+ * module name and template path within module.
+ */
+return [
+    ['Magento_Braintree', 'view/frontend/templates/paypal/button_shopping_cart.phtml']
+];