Skip to content

Commit af4a2d3

Browse files
committed
MC-42290: Check bind changes are covered by test
- Add some validations to the test
1 parent e7f6670 commit af4a2d3

File tree

5 files changed

+56
-5
lines changed

5 files changed

+56
-5
lines changed
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminClickViewThemeActionGroup">
12+
<annotations>
13+
<description>Clicks on 'View' action of one theme on the themes grid.</description>
14+
</annotations>
15+
<click selector="{{AdminThemeSection.viewAction}}" stepKey="clickViewTheme"/>
16+
</actionGroup>
17+
</actionGroups>

app/code/Magento/Theme/Test/Mftf/Data/AdminMenuData.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,4 @@
1313
<data key="title">Themes</data>
1414
<data key="dataUiId">magento-theme-system-design-theme</data>
1515
</entity>
16-
<entity name="MagentoBlankEditTheme">
17-
<data key="pageTitle">Theme: Magento Blank</data>
18-
</entity>
1916
</entities>
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:DataGenerator/etc/dataProfileSchema.xsd">
11+
<entity name="MagentoBlankTheme">
12+
<data key="pageTitle">Theme: Magento Blank</data>
13+
<data key="themePath">Magento/blank</data>
14+
<data key="themeTitle">Magento Blank</data>
15+
</entity>
16+
</entities>
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
11+
<section name="AdminThemeSettingsSection">
12+
<element name="themePath" type="text" selector=".field-theme_path"/>
13+
<element name="themeTitle" type="text" selector=".field-theme_title"/>
14+
<element name="themePreviewImage" type="text" selector="//div[contains(@class, 'field-preview_image')]//label//span[contains(text(), 'Theme Preview Image')]"/>
15+
</section>
16+
</sections>

app/code/Magento/Theme/Test/Mftf/Test/AdminContentThemesEditTest.xml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,14 @@
3232
<argument name="title" value="{{AdminMenuContentDesignThemes.pageTitle}}"/>
3333
</actionGroup>
3434

35-
<click selector="{{AdminThemeSection.viewAction}}" stepKey="clickViewTheme"/>
35+
<actionGroup ref="AdminClickViewThemeActionGroup" stepKey="editTheme"/>
36+
3637
<actionGroup ref="AdminAssertPageTitleActionGroup" stepKey="seeEditPageTitle">
37-
<argument name="title" value="{{MagentoBlankEditTheme.pageTitle}}"/>
38+
<argument name="title" value="{{MagentoBlankTheme.pageTitle}}"/>
3839
</actionGroup>
40+
41+
<see selector="{{AdminThemeSettingsSection.themePath}}" userInput="{{MagentoBlankTheme.themePath}}" stepKey="assertThemePath"/>
42+
<see selector="{{AdminThemeSettingsSection.themeTitle}}" userInput="{{MagentoBlankTheme.themeTitle}}" stepKey="assertThemeTitle"/>
43+
<seeElementInDOM selector="{{AdminThemeSettingsSection.themePreviewImage}}" stepKey="seeThemePreviewImage"/>
3944
</test>
4045
</tests>

0 commit comments

Comments
 (0)