Skip to content

Commit a8ae74e

Browse files
MAGETWO-66666: Adding a product to cart from category page with an expired session does not allow product to be added
- Add automated test
1 parent 9d204cf commit a8ae74e

File tree

4 files changed

+32
-29
lines changed

4 files changed

+32
-29
lines changed

app/code/Magento/Customer/Test/Mftf/ActionGroup/StorefrontAddProductToCardActionGroup.xml

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,7 @@
3131
<see userInput="You saved the product." stepKey="seeSaveConfirmation"/>
3232
</actionGroup>
3333

34-
3534
<actionGroup name="FindAndAddProductToCardActionGroup">
36-
<arguments>
37-
<argument name="product" defaultValue="SimpleProductOne"/>
38-
</arguments>
39-
4035
<click selector="{{StorefrontAddProductToCartSection.addToCartBtn}}" stepKey="addToCart"/>
4136
<waitForElementVisible selector="{{StorefrontProductPageSection.successMsg}}" time="30" stepKey="waitForProductAdded"/>
4237
<click selector="{{StorefrontAddProductToCartSection.showCard}}" stepKey="clickToOpenCard"/>
@@ -46,30 +41,20 @@
4641
<see userInput="Shipping Address" stepKey="seeShippingAddress"/>
4742
</actionGroup>
4843

49-
50-
<actionGroup name="AgainGoToProductCategory">
51-
52-
<amOnPage url="/admin" stepKey="GoToDashboard"/>
53-
54-
<click selector="{{GoToProductPageSection.catalog}}" stepKey="clickOnCatalog" />
55-
<waitForPageLoad stepKey="waitForPage"/>
56-
<click selector="{{GoToProductPageSection.product}}" stepKey="clickToSelectProductsItem" />
57-
<waitForPageLoad stepKey="waitForPageProducts"/>
58-
</actionGroup>
59-
6044
<actionGroup name="DeleteCreatedProduct">
61-
62-
<click selector="{{DeleteCreatedProduct.createdProductID(SimpleProductOne.name)}}" stepKey="selectCreatedProduct"/>
45+
<fillField stepKey="searchToKeyword" selector="{{DeleteCreatedProduct.searchToKeyword}}" userInput="{{SimpleProductOne.name}}"/>
46+
<click stepKey="clickSearchButton" selector="{{DeleteCreatedProduct.searchButton}}"/>
47+
<wait stepKey="waitForFiltering" time="2"/>
48+
<click selector="{{DeleteCreatedProduct.createdProductID}}" stepKey="selectCreatedProduct"/>
6349
<wait stepKey="waitSelectCreatedProduct" time="2"/>
6450
<waitForElementVisible selector="{{DeleteCreatedProduct.actionSelectBox}}" stepKey="waitToSelectActionVisible" time="50"/>
6551
<click stepKey="clickToSelectAction" selector="{{DeleteCreatedProduct.actionSelectBox}}"/>
66-
<wait stepKey="waitClickToSelectAction" time="2"/>
52+
<waitForElementVisible selector="{{DeleteCreatedProduct.deleteButton}}" stepKey="waitForDeleteButtonAppeared" time="2"/>
6753
<click selector="{{DeleteCreatedProduct.deleteButton}}" stepKey="clickToDeleteProduct"/>
68-
<wait stepKey="waitClickToDeleteProduct" time="2"/>
54+
<waitForElementVisible selector="{{DeleteCreatedProduct.okButton}}" stepKey="waitForOkButtonAppeared" time="2"/>
6955
<click selector="{{DeleteCreatedProduct.okButton}}" stepKey="clickToConfirm"/>
70-
<wait stepKey="waitClickToConfirmButton" time="2"/>
56+
<wait stepKey="waitForRecordIsDeleted" time="2"/>
7157
<see userInput="A total of 1 record(s) have been deleted." stepKey="productDeletedSuccessfully"/>
72-
7358
</actionGroup>
7459

7560
</actionGroups>
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/DataGenerator/etc/dataProfileSchema.xsd">
11+
<entity name="SimpleProductOne" type="product">
12+
<data key="name" unique="suffix">testProduct</data>
13+
<data key="sku" unique="suffix">testSku</data>
14+
<data key="price">200</data>
15+
<data key="quantity">100</data>
16+
<data key="urlKey" unique="suffix">testProduct</data>
17+
</entity>
18+
</entities>

app/code/Magento/Customer/Test/Mftf/Section/StorefrontAddProductToCardSection.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
<element name="successMsg" type="button" selector="div.message-success"/>
1414
<element name="showCard" type="button" selector=".action.showcart"/>
1515
<element name="proceed" type="button" selector="#top-cart-btn-checkout"/>
16-
1716
</section>
1817

1918
<section name="GoToProductPageSection">
@@ -59,13 +58,14 @@
5958
<element name="searchOptimization" type="button" selector="//*[contains(text(),'Search Engine Optimization')]"/>
6059
<element name="urlKey" type="input" selector="//input[contains(@name,'url_key')]"/>
6160
<element name="saveButton" type="button" selector="#save-button"/>
62-
6361
</section>
6462

6563
<section name="DeleteCreatedProduct">
66-
<element name="createdProductID" type="select" selector="//*[@id='container']//*[text()='{{arg1}}']/parent::td/parent::tr//label[contains(@class, 'data-grid-checkbox-cell-inner')]" parameterized="true"/>
67-
<element name="actionSelectBox" type="button" selector="//*[@class='col-xs-2']"/>
68-
<element name="deleteButton" type="button" selector="//*[@class='admin__data-grid-header-row row row-gutter']//*[text()='Delete']"/>
64+
<element name="searchToKeyword" type="input" selector="//*[@class='admin__data-grid-outer-wrap']/*[@class='admin__data-grid-header']//*[@class='data-grid-search-control-wrap']/input"/>
65+
<element name="searchButton" type="button" selector="//*[@class='admin__data-grid-outer-wrap']/*[@class='admin__data-grid-header']//*[@class='data-grid-search-control-wrap']/button"/>
66+
<element name="createdProductID" type="select" selector="//*[@class='data-grid-checkbox-cell-inner']/input"/>
67+
<element name="actionSelectBox" type="button" selector="//*[@class='col-xs-2']//span[text()='Actions']"/>
68+
<element name="deleteButton" type="button" selector="//div[@class='col-xs-2']//*[text()='Delete']"/>
6969
<element name="okButton" type="button" selector=".action-primary.action-accept"/>
7070
</section>
7171

app/code/Magento/Customer/Test/Mftf/Test/AddingProductWithExpiredSessionTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@
4040

4141
<after>
4242
<!--Delete created product-->
43-
<actionGroup ref="AgainGoToProductCategory" stepKey="againGoToProductCategory"/>
44-
<wait stepKey="waitForProductPageLoaded" time="3"/>
43+
<amOnPage url="/admin" stepKey="GoToDashboard"/>
44+
<actionGroup ref="GoToProductPage" stepKey="againGoToProductPage"/>
4545
<actionGroup ref="DeleteCreatedProduct" stepKey="deleteCreatedProduct"/>
4646
</after>
4747

0 commit comments

Comments
 (0)