Clean expired quotes - Fix out of memory on huge quotes list

Author: ihor-sviziev

dev/tests/integration/testsuite/Magento/Sales/Cron/CleanExpiredQuotesTest.php

@@ -25,16 +25,6 @@ class CleanExpiredQuotesTest extends \PHPUnit\Framework\TestCase
      */
     private $cleanExpiredQuotes;
 
-    /**
-     * @var QuoteRepository
-     */
-    private $quoteRepository;
-
-    /**
-     * @var SearchCriteriaBuilder
-     */
-    private $searchCriteriaBuilder;
-
     /**
      * @var QuoteCollectionFactory
      */
@@ -47,8 +37,6 @@ protected function setUp()
     {
         $objectManager = Bootstrap::getObjectManager();
         $this->cleanExpiredQuotes = $objectManager->get(CleanExpiredQuotes::class);
-        $this->quoteRepository = $objectManager->get(QuoteRepository::class);
-        $this->searchCriteriaBuilder = $objectManager->get(SearchCriteriaBuilder::class);
         $this->quoteCollectionFactory = $objectManager->get(QuoteCollectionFactory::class);
     }
 
@@ -60,18 +48,14 @@ protected function setUp()
      */
     public function testExecute()
     {
-        $searchCriteria = $this->searchCriteriaBuilder->create();
         //Initial count - should be equal to stores number.
-        $this->assertEquals(2, $this->quoteRepository->getList($searchCriteria)->getTotalCount());
+        $this->assertQuotesCount(2);
 
         //Deleting expired quotes
         $this->cleanExpiredQuotes->execute();
-        $totalCount = $this->quoteRepository->getList($searchCriteria)->getTotalCount();
+
         //Only 1 will be deleted for the store that has all of them expired by config (default_store)
-        $this->assertEquals(
-            1,
-            $totalCount
-        );
+        $this->assertQuotesCount(1);
     }
 
     /**
@@ -83,14 +67,24 @@ public function testExecute()
     public function testExecuteWithBigAmountOfQuotes()
     {
         //Initial count - should be equal to 1000
-        //Use collection getSize in order to get quick result
-        $this->assertEquals(1000, $this->quoteCollectionFactory->create()->getSize());
+        $this->assertQuotesCount(1000);
 
         //Deleting expired quotes
         $this->cleanExpiredQuotes->execute();
-        $totalCount = $this->quoteCollectionFactory->create()->getSize();
 
         //There should be no quotes anymore
-        $this->assertEquals(0, $totalCount);
+        $this->assertQuotesCount(0);
+    }
+
+    /**
+     * Optimized assert quotes count
+     * Uses collection getSize in order to get quick result
+     *
+     * @param int $expected
+     */
+    private function assertQuotesCount(int $expected): void
+    {
+        $totalCount = $this->quoteCollectionFactory->create()->getSize();
+        $this->assertEquals($expected, $totalCount);
     }
 }