MAGETWO-52170: Impossible to create Downloadable Product - review fixes

Author: valdislav

app/code/Magento/Downloadable/Model/LinkRepository.php

@@ -184,7 +184,7 @@ public function save($sku, LinkInterface $link, $isGlobalScopeContent = true)
                 throw new InputException(__('Provided link information is invalid.'));
             }
 
-            if (!($link->getLinkType() === 'url' || $link->getLinkType() === 'file')) {
+            if (!in_array($link->getLinkType(), ['url', 'file'], true)) {
                 throw new InputException(__('Invalid link type.'));
             }
             $title = $link->getTitle();

app/code/Magento/Downloadable/Model/Sample/Builder.php

@@ -99,6 +99,9 @@ public function build(SampleInterface $sample)
             SampleInterface::class
         );
         if ($sample->getSampleType() === \Magento\Downloadable\Helper\Download::LINK_TYPE_FILE) {
+            if (!isset($this->data['file'])) {
+                throw new \Magento\Framework\Exception\LocalizedException(__('Sample file not provided'));
+            }
             $fileName = $this->downloadableFile->moveFileFromTmp(
                 $this->getComponent()->getBaseTmpPath(),
                 $this->getComponent()->getBasePath(),

app/code/Magento/Downloadable/Model/SampleRepository.php

@@ -190,7 +190,7 @@ public function save(
                 throw new InputException(__('Provided sample information is invalid.'));
             }
 
-            if (!($sample->getSampleType() === 'url' || $sample->getSampleType() === 'file')) {
+            if (!in_array($sample->getSampleType(), ['url', 'file'], true)) {
                 throw new InputException(__('Invalid sample type.'));
             }