Adding returning strict typing

eduard13 · eduard13 · commit 82f5511ee558 · 2019-01-28T15:40:21.000+02:00
diff --git a/app/code/Magento/Eav/Model/Validator/Attribute/Code.php b/app/code/Magento/Eav/Model/Validator/Attribute/Code.php
@@ -22,11 +22,11 @@ class Code  extends AbstractValidator
     /**
      * Validates the correctness of the attribute code
      *
-     * @param $attributeCode
+     * @param string $attributeCode
      * @return bool
      * @throws LocalizedException
      */
-    public function isValid($attributeCode)
+    public function isValid($attributeCode): bool
     {
         /**
          * Check attribute_code for allowed characters

Original file line number	Diff line number	Diff line change
`@@ -22,11 +22,11 @@ class Code extends AbstractValidator`
`22`	`22`	`/**`
`23`	`23`	`* Validates the correctness of the attribute code`
`24`	`24`	`*`
`25`		`- * @param $attributeCode`
	`25`	`+ * @param string $attributeCode`
`26`	`26`	`* @return bool`
`27`	`27`	`* @throws LocalizedException`
`28`	`28`	`*/`
`29`		`- public function isValid($attributeCode)`
	`29`	`+ public function isValid($attributeCode): bool`
`30`	`30`	`{`
`31`	`31`	`/**`
`32`	`32`	`* Check attribute_code for allowed characters`