Fixed Changing sample for downloadable product failure

ravi-chandra3197 · ravi-chandra3197 · commit 7cd48fc3b92c · 2019-04-05T10:30:36.000+05:30
diff --git a/app/code/Magento/Downloadable/Model/SampleRepository.php b/app/code/Magento/Downloadable/Model/SampleRepository.php
@@ -308,8 +308,11 @@ protected function updateSample(
             $existingSample->setTitle($sample->getTitle());
         }
 
-        if ($sample->getSampleType() === 'file' && $sample->getSampleFileContent() === null) {
-            $sample->setSampleFile($existingSample->getSampleFile());
+        if ($sample->getSampleType() === 'file'
+            && $sample->getSampleFileContent() === null
+            && $sample->getSampleFile() !== null
+        ) {
+            $existingSample->setSampleFile($sample->getSampleFile());
         }
         $this->saveSample($product, $sample, $isGlobalScopeContent);
         return $existingSample->getId();

Original file line number	Diff line number	Diff line change
`@@ -308,8 +308,11 @@ protected function updateSample(`
`308`	`308`	`$existingSample->setTitle($sample->getTitle());`
`309`	`309`	`}`
`310`	`310`
`311`		`- if ($sample->getSampleType() === 'file' && $sample->getSampleFileContent() === null) {`
`312`		`- $sample->setSampleFile($existingSample->getSampleFile());`
	`311`	`+ if ($sample->getSampleType() === 'file'`
	`312`	`+ && $sample->getSampleFileContent() === null`
	`313`	`+ && $sample->getSampleFile() !== null`
	`314`	`+ ) {`
	`315`	`+ $existingSample->setSampleFile($sample->getSampleFile());`
`313`	`316`	`}`
`314`	`317`	`$this->saveSample($product, $sample, $isGlobalScopeContent);`
`315`	`318`	`return $existingSample->getId();`