Skip to content

Commit 79fdffb

Browse files
committed
Add validation in catalog rule and shopping cart rule form
1 parent abbfa03 commit 79fdffb

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

app/code/Magento/CatalogRule/view/adminhtml/ui_component/catalog_rule_form.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,10 @@
208208
</item>
209209
</argument>
210210
<settings>
211+
<validation>
212+
<rule name="validate-number" xsi:type="boolean">true</rule>
213+
<rule name="validate-zero-or-greater" xsi:type="boolean">true</rule>
214+
</validation>
211215
<dataType>text</dataType>
212216
<label translate="true">Priority</label>
213217
<dataScope>sort_order</dataScope>

app/code/Magento/SalesRule/view/adminhtml/ui_component/sales_rule_form.xml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,9 @@
297297
</item>
298298
</argument>
299299
<settings>
300+
<validation>
301+
<rule name="validate-digits" xsi:type="boolean">true</rule>
302+
</validation>
300303
<dataType>text</dataType>
301304
<label translate="true">Uses per Coupon</label>
302305
<dataScope>uses_per_coupon</dataScope>
@@ -309,6 +312,9 @@
309312
</item>
310313
</argument>
311314
<settings>
315+
<validation>
316+
<rule name="validate-digits" xsi:type="boolean">true</rule>
317+
</validation>
312318
<notice translate="true">
313319
Usage limit enforced for logged in customers only.
314320
</notice>
@@ -356,6 +362,10 @@
356362
</item>
357363
</argument>
358364
<settings>
365+
<validation>
366+
<rule name="validate-number" xsi:type="boolean">true</rule>
367+
<rule name="validate-zero-or-greater" xsi:type="boolean">true</rule>
368+
</validation>
359369
<dataType>text</dataType>
360370
<label translate="true">Priority</label>
361371
<dataScope>sort_order</dataScope>
@@ -422,6 +432,8 @@
422432
<settings>
423433
<validation>
424434
<rule name="required-entry" xsi:type="boolean">true</rule>
435+
<rule name="validate-number" xsi:type="boolean">true</rule>
436+
<rule name="validate-zero-or-greater" xsi:type="boolean">true</rule>
425437
</validation>
426438
<dataType>text</dataType>
427439
<label translate="true">Discount Amount</label>
@@ -435,6 +447,10 @@
435447
</item>
436448
</argument>
437449
<settings>
450+
<validation>
451+
<rule name="validate-number" xsi:type="boolean">true</rule>
452+
<rule name="validate-zero-or-greater" xsi:type="boolean">true</rule>
453+
</validation>
438454
<dataType>text</dataType>
439455
<label translate="true">Maximum Qty Discount is Applied To</label>
440456
<dataScope>discount_qty</dataScope>
@@ -447,6 +463,10 @@
447463
</item>
448464
</argument>
449465
<settings>
466+
<validation>
467+
<rule name="validate-number" xsi:type="boolean">true</rule>
468+
<rule name="validate-zero-or-greater" xsi:type="boolean">true</rule>
469+
</validation>
450470
<dataType>text</dataType>
451471
<label translate="true">Discount Qty Step (Buy X)</label>
452472
<dataScope>discount_step</dataScope>

0 commit comments

Comments
 (0)