Skip to content

Commit 7858941

Browse files
author
Mateusz Krzeszowiak
committed
Position stage instead of image for more stable layout
1 parent de944ad commit 7858941

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

lib/web/mage/gallery/gallery.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,8 @@ define([
272272
}),
273273
mainImageIndex,
274274
$element = settings.$element,
275-
$placeholderImage = $element.find('.gallery-placeholder__image'),
276-
$fotoramaElement;
275+
$fotoramaElement,
276+
$fotoramaStage;
277277

278278
if (settings.breakpoints) {
279279
_.each(_.values(settings.breakpoints), function (breakpoint) {
@@ -297,25 +297,25 @@ define([
297297
);
298298
settings.currentConfig = config;
299299

300-
// Adjust wrapper and placeholder styling just before initializing the gallery.
301-
$placeholderImage.css({
302-
position: 'absolute',
303-
left: '50%',
304-
transform: 'translateX(-50%)'
305-
});
306300
$element
307301
.css('min-height', settings.$element.height())
308302
.append(tpl);
309303

310304
$fotoramaElement = $element.find('[data-gallery-role="gallery"]');
305+
306+
$fotoramaStage = $fotoramaElement.find('.fotorama__stage');
307+
$fotoramaStage.css('position', 'absolute');
308+
311309
$fotoramaElement.fotorama(config);
312310
$fotoramaElement.find('.fotorama__stage__frame.fotorama__active')
313311
.one('f:load', function () {
314312
// Remove placeholder when main gallery image loads.
315-
$placeholderImage.remove();
313+
$element.find('.gallery-placeholder__image').remove();
316314
$element
317315
.removeClass('_block-content-loading')
318316
.css('min-height', '');
317+
318+
$fotoramaStage.css('position', '');
319319
});
320320
settings.$elementF = $fotoramaElement;
321321
settings.fotoramaApi = $fotoramaElement.data('fotorama');

0 commit comments

Comments
 (0)