minor refactor

engcom-Charlie · engcom-Charlie · commit 74325ef39fd1 · 2020-09-04T15:46:53.000+03:00
diff --git a/app/code/Magento/Widget/Model/Widget.php b/app/code/Magento/Widget/Model/Widget.php
@@ -310,10 +310,14 @@ public function getWidgetDeclaration($type, $params = [], $asIs = true)
     {
         $widget = $this->getConfigAsObject($type);
 
+        $params = array_filter($params, function ($value) {
+            return $value !== null;
+        });
+
         $directiveParams = '';
         foreach ($params as $name => $value) {
             // Retrieve default option value if pre-configured
-            $directiveParams .= $value === null ? '' : $this->getDirectiveParam($widget, $name, $value);
+            $directiveParams .= $this->getDirectiveParam($widget, $name, $value);
         }
 
         $directive = sprintf('{{widget type="%s"%s%s}}', $type, $directiveParams, $this->getWidgetPageVarName($params));

Original file line number	Diff line number	Diff line change
`@@ -310,10 +310,14 @@ public function getWidgetDeclaration($type, $params = [], $asIs = true)`
`310`	`310`	`{`
`311`	`311`	`$widget = $this->getConfigAsObject($type);`
`312`	`312`
	`313`	`+ $params = array_filter($params, function ($value) {`
	`314`	`+ return $value !== null;`
	`315`	`+ });`
	`316`	`+`
`313`	`317`	`$directiveParams = '';`
`314`	`318`	`foreach ($params as $name => $value) {`
`315`	`319`	`// Retrieve default option value if pre-configured`
`316`		`- $directiveParams .= $value === null ? '' : $this->getDirectiveParam($widget, $name, $value);`
	`320`	`+ $directiveParams .= $this->getDirectiveParam($widget, $name, $value);`
`317`	`321`	`}`
`318`	`322`
`319`	`323`	`$directive = sprintf('{{widget type="%s"%s%s}}', $type, $directiveParams, $this->getWidgetPageVarName($params));`