Skip to content

Commit 6bb24ef

Browse files
committed
#21734 Error in JS validation rule
1 parent 71e61a7 commit 6bb24ef

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -919,12 +919,12 @@ define([
919919
],
920920
'validate-per-page-value-list': [
921921
function (value) {
922-
var isValid = utils.isEmpty(value),
922+
var isValid = true,
923923
values = value.split(','),
924924
i;
925925

926-
if (isValid) {
927-
return true;
926+
if (utils.isEmpty(value)) {
927+
return isValid;
928928
}
929929

930930
for (i = 0; i < values.length; i++) {

lib/web/mage/validation.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1425,10 +1425,14 @@
14251425
],
14261426
'validate-per-page-value-list': [
14271427
function (v) {
1428-
var isValid = !$.mage.isEmpty(v),
1428+
var isValid = true,
14291429
values = v.split(','),
14301430
i;
14311431

1432+
if ($.mage.isEmpty(v)) {
1433+
return isValid;
1434+
}
1435+
14321436
for (i = 0; i < values.length; i++) {
14331437
if (!/^[0-9]+$/.test(values[i])) {
14341438
isValid = false;

0 commit comments

Comments
 (0)