Skip to content

Commit 61e59b3

Browse files
committed
ACP2E-2125: adjusted email validator condition
1 parent 64f4fd8 commit 61e59b3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/code/Magento/Sales/Model/Order/Address/Validator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public function validate(Address $address)
104104

105105
$email = $address->getEmail();
106106

107-
if (empty($email) || $this->emailAddressValidator->isValid($email)) {
107+
if (empty($email) || !$this->emailAddressValidator->isValid($email)) {
108108
$warnings[] = 'Email has a wrong format';
109109
}
110110

app/code/Magento/Sales/Test/Unit/Model/Order/Address/ValidatorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public function testValidate($addressData, $email, $addressType, $expectedWarnin
9595
$this->emailValidatorMock->expects($this->once())
9696
->method('isValid')
9797
->with($email)
98-
->willReturn((stripos($email, '@') === false));
98+
->willReturn((stripos($email, '@') !== false));
9999
$actualWarnings = $this->validator->validate($this->addressMock);
100100
$this->assertEquals($expectedWarnings, $actualWarnings);
101101
}

0 commit comments

Comments
 (0)