Skip to content

Commit 60d8759

Browse files
ENGCOM-6299: Uses > Used for Yes/No column in coupons grid #25658
2 parents 471f582 + cf20a05 commit 60d8759

File tree

4 files changed

+6
-1
lines changed

4 files changed

+6
-1
lines changed

app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Grid.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ protected function _prepareColumns()
100100
$this->addColumn(
101101
'used',
102102
[
103-
'header' => __('Uses'),
103+
'header' => __('Used'),
104104
'index' => 'times_used',
105105
'width' => '100',
106106
'type' => 'options',

app/code/Magento/SalesRule/Test/Mftf/Section/AdminCartPriceRulesFormSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,5 +98,6 @@
9898
<element name="couponQty" type="input" selector="#coupons_qty"/>
9999
<element name="generateCouponsButton" type="button" selector="#coupons_generate_button" timeout="30"/>
100100
<element name="generatedCouponByIndex" type="text" selector="#couponCodesGrid_table > tbody > tr:nth-child({{var}}) > td.col-code" parameterized="true"/>
101+
<element name="couponGridUsedHeader" type="text" selector="#couponCodesGrid thead th[data-sort='used']"/>
101102
</section>
102103
</sections>

app/code/Magento/SalesRule/Test/Mftf/Test/AdminCreateCartPriceRuleForGeneratedCouponTest.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,9 @@
6262
<waitForPageLoad stepKey="waitFormToReload1"/>
6363
<click selector="{{AdminCartPriceRulesFormSection.manageCouponCodesHeader}}" stepKey="expandCouponSection2"/>
6464

65+
<!-- Assert coupon codes grid header is correct -->
66+
<see selector="{{AdminCartPriceRulesFormSection.couponGridUsedHeader}}" userInput="Used" stepKey="seeCorrectUsedHeader"/>
67+
6568
<!-- Grab a coupon code and hold on to it for later -->
6669
<grabTextFrom selector="{{AdminCartPriceRulesFormSection.generatedCouponByIndex('1')}}" stepKey="grabCouponCode"/>
6770

app/code/Magento/SalesRule/i18n/en_US.csv

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ Conditions,Conditions
2222
Generate,Generate
2323
"Coupon Code","Coupon Code"
2424
Created,Created
25+
Used,Used
2526
Uses,Uses
2627
No,No
2728
Yes,Yes

0 commit comments

Comments
 (0)