Merge pull request #57 from magento-api/MAGETWO-39663-NEW-Product-Save-Through-API-Service-Is-Not-Visible-On-Frontend

[API+FearlessKiwis+Vanilla] MAGETWO-39663 Product save through API, MAGETWO-44491 revert executeInternal to execute, Frontend Bug Fixes

Author: Tang, Yu(ytang1)

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/AjaxMarkAsRead.php

@@ -13,7 +13,7 @@ class AjaxMarkAsRead extends \Magento\AdminNotification\Controller\Adminhtml\Not
      *
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         if (!$this->getRequest()->getPostValue()) {
             return;

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/Index.php

@@ -11,7 +11,7 @@ class Index extends \Magento\AdminNotification\Controller\Adminhtml\Notification
     /**
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         $this->_view->loadLayout();
         $this->_setActiveMenu(

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MarkAsRead.php

@@ -11,7 +11,7 @@ class MarkAsRead extends \Magento\AdminNotification\Controller\Adminhtml\Notific
     /**
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         $notificationId = (int)$this->getRequest()->getParam('id');
         if ($notificationId) {

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MassMarkAsRead.php

@@ -11,7 +11,7 @@ class MassMarkAsRead extends \Magento\AdminNotification\Controller\Adminhtml\Not
     /**
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         $ids = $this->getRequest()->getParam('notification');
         if (!is_array($ids)) {

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MassRemove.php

@@ -11,7 +11,7 @@ class MassRemove extends \Magento\AdminNotification\Controller\Adminhtml\Notific
     /**
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         $ids = $this->getRequest()->getParam('notification');
         if (!is_array($ids)) {

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/Remove.php

@@ -11,7 +11,7 @@ class Remove extends \Magento\AdminNotification\Controller\Adminhtml\Notificatio
     /**
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         if ($id = $this->getRequest()->getParam('id')) {
             $model = $this->_objectManager->create('Magento\AdminNotification\Model\Inbox')->load($id);

app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php

@@ -38,7 +38,7 @@ public function __construct(
     /**
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         $severity = $this->getRequest()->getParam('severity');
         if ($severity) {

app/code/Magento/AdvancedPricingImportExport/Controller/Adminhtml/Export/GetFilter.php

@@ -17,7 +17,7 @@ class GetFilter extends ExportController
      *
      * @return \Magento\Framework\Controller\ResultInterface
      */
-    public function executeInternal()
+    public function execute()
     {
         $data = $this->getRequest()->getParams();
         if ($this->getRequest()->isXmlHttpRequest() && $data) {

app/code/Magento/Authorizenet/Controller/Adminhtml/Authorizenet/Directpost/Payment/Place.php

@@ -51,7 +51,7 @@ public function __construct(
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.UnusedLocalVariable)
      */
-    public function executeInternal()
+    public function execute()
     {
         $paymentParam = $this->getRequest()->getParam('payment');
         $controller = $this->getRequest()->getParam('controller');

app/code/Magento/Authorizenet/Controller/Adminhtml/Authorizenet/Directpost/Payment/Redirect.php

@@ -90,7 +90,7 @@ protected function _returnQuote($cancelOrder, $errorMsg)
      *
      * @return \Magento\Framework\View\Result\Layout
      */
-    public function executeInternal()
+    public function execute()
     {
         $redirectParams = $this->getRequest()->getParams();
         $params = [];

app/code/Magento/Authorizenet/Controller/Adminhtml/Authorizenet/Directpost/Payment/ReturnQuote.php

@@ -31,7 +31,7 @@ protected function _returnQuote()
      *
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         $this->_returnQuote();
         $this->getResponse()->representJson(

app/code/Magento/Authorizenet/Controller/Directpost/Payment/BackendResponse.php

@@ -14,7 +14,7 @@ class BackendResponse extends \Magento\Authorizenet\Controller\Directpost\Paymen
      *
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         $this->_responseAction('adminhtml');
     }

app/code/Magento/Authorizenet/Controller/Directpost/Payment/Place.php

@@ -71,7 +71,7 @@ public function __construct(
      *
      * @return string
      */
-    public function executeInternal()
+    public function execute()
     {
         $paymentParam = $this->getRequest()->getParam('payment');
         $controller = $this->getRequest()->getParam('controller');

app/code/Magento/Authorizenet/Controller/Directpost/Payment/Redirect.php

@@ -15,7 +15,7 @@ class Redirect extends \Magento\Authorizenet\Controller\Directpost\Payment
      *
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         $helper = $this->dataFactory->create('frontend');
 

app/code/Magento/Authorizenet/Controller/Directpost/Payment/Response.php

@@ -14,7 +14,7 @@ class Response extends \Magento\Authorizenet\Controller\Directpost\Payment
      *
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         $this->_responseAction('frontend');
     }

app/code/Magento/Authorizenet/Controller/Directpost/Payment/ReturnQuote.php

@@ -13,7 +13,7 @@ class ReturnQuote extends \Magento\Authorizenet\Controller\Directpost\Payment
      *
      * @return void
      */
-    public function executeInternal()
+    public function execute()
     {
         $this->_returnCustomerQuote();
         $this->getResponse()->representJson(

app/code/Magento/Authorizenet/Test/Unit/Controller/Adminhtml/Authorizenet/Directpost/Payment/RedirectTest.php

@@ -96,11 +96,6 @@ class RedirectTest extends \PHPUnit_Framework_TestCase
      */
     protected $helperMock;
 
-    /**
-     * @var Redirect|\PHPUnit_Framework_MockObject_MockObject
-     */
-    protected $controller;
-
     protected function setUp()
     {
         $this->directpostSessionMock = $this->getMockBuilder('Magento\Authorizenet\Model\Directpost\Session')
@@ -201,7 +196,7 @@ protected function setUp()
         );
     }
 
-    public function testExecuteInternalErrorMsgWithoutCancelOrder()
+    public function testExecuteErrorMsgWithoutCancelOrder()
     {
         $params = ['success' => 0, 'error_msg' => 'Error message'];
         $incrementId = 1;
@@ -243,10 +238,10 @@ public function testExecuteInternalErrorMsgWithoutCancelOrder()
             ->method('register')
             ->with(Iframe::REGISTRY_KEY);
 
-        $this->assertInstanceOf('\Magento\Framework\View\Result\Layout', $this->controller->executeInternal());
+        $this->assertInstanceOf('\Magento\Framework\View\Result\Layout', $this->controller->execute());
     }
 
-    public function testExecuteInternalErrorMsgWithCancelOrder()
+    public function testExecuteErrorMsgWithCancelOrder()
     {
         $params = ['success' => 0, 'error_msg' => 'Error message', 'x_invoice_num' => 1];
         $incrementId = 1;
@@ -278,10 +273,10 @@ public function testExecuteInternalErrorMsgWithCancelOrder()
             ->method('register')
             ->with(Iframe::REGISTRY_KEY);
 
-        $this->assertInstanceOf('\Magento\Framework\View\Result\Layout', $this->controller->executeInternal());
+        $this->assertInstanceOf('\Magento\Framework\View\Result\Layout', $this->controller->execute());
     }
 
-    public function testExecuteInternalSuccess()
+    public function testExecuteSuccess()
     {
         $params = ['success' => 1, 'controller_action_name' => 'action', 'x_invoice_num' => 1];
         $this->requestMock->expects($this->once())
@@ -312,6 +307,6 @@ public function testExecuteInternalSuccess()
             ->method('register')
             ->with(Iframe::REGISTRY_KEY);
 
-        $this->assertInstanceOf('\Magento\Framework\View\Result\Layout', $this->controller->executeInternal());
+        $this->assertInstanceOf('\Magento\Framework\View\Result\Layout', $this->controller->execute());
     }
 }

app/code/Magento/Authorizenet/Test/Unit/Controller/Directpost/Payment/PlaceTest.php

@@ -205,7 +205,7 @@ public function testExecute(
             ->method('jsonEncode')
             ->with($result);
 
-        $this->placeOrderController->executeInternal();
+        $this->placeOrderController->execute();
     }
 
     /**
@@ -243,7 +243,7 @@ public function testExecuteFailedPlaceOrder(
             ->method('jsonEncode')
             ->with($result);
 
-        $this->placeOrderController->executeInternal();
+        $this->placeOrderController->execute();
     }
 
     /**

app/code/Magento/Backend/App/AbstractAction.php

@@ -200,10 +200,10 @@ private function _moveBlockToContainer(\Magento\Framework\View\Element\AbstractB
      * @param \Magento\Framework\App\RequestInterface $request
      * @return \Magento\Framework\App\ResponseInterface
      */
-    public function execute(\Magento\Framework\App\RequestInterface $request)
+    public function dispatch(\Magento\Framework\App\RequestInterface $request)
     {
         if (!$this->_processUrlKeys()) {
-            return parent::execute($request);
+            return parent::dispatch($request);
         }
 
         if ($request->isDispatched() && $request->getActionName() !== 'denied' && !$this->_isAllowed()) {
@@ -223,7 +223,7 @@ public function execute(\Magento\Framework\App\RequestInterface $request)
 
         $this->_processLocaleSettings();
 
-        return parent::execute($request);
+        return parent::dispatch($request);
     }
 
     /**

app/code/Magento/Backend/App/Action/Plugin/Authentication.php

@@ -101,7 +101,7 @@ public function __construct(
      * @return mixed
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function aroundExecute(
+    public function aroundDispatch(
         \Magento\Backend\App\AbstractAction $subject,
         \Closure $proceed,
         \Magento\Framework\App\RequestInterface $request

app/code/Magento/Backend/App/Action/Plugin/MassactionKey.php

@@ -19,7 +19,7 @@ class MassactionKey
      * @return mixed
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function aroundExecute(
+    public function aroundDispatch(
         \Magento\Backend\App\AbstractAction $subject,
         \Closure $proceed,
         \Magento\Framework\App\RequestInterface $request

app/code/Magento/Backend/Controller/Adminhtml/Ajax/Translate.php

@@ -40,7 +40,7 @@ public function __construct(
      *
      * @return \Magento\Framework\Controller\Result\Json
      */
-    public function executeInternal()
+    public function execute()
     {
         $translate = (array)$this->getRequest()->getPost('translate');
 

app/code/Magento/Backend/Controller/Adminhtml/Auth/DeniedIframe.php

@@ -41,7 +41,7 @@ protected function _getDeniedIframe()
      *
      * @return \Magento\Framework\Controller\Result\Raw
      */
-    public function executeInternal()
+    public function execute()
     {
         /** @var \Magento\Framework\Controller\Result\Raw $resultRaw */
         $resultRaw = $this->resultRawFactory->create();

app/code/Magento/Backend/Controller/Adminhtml/Auth/DeniedJson.php

@@ -43,7 +43,7 @@ protected function _getDeniedJson()
      *
      * @return \Magento\Framework\Controller\Result\Json
      */
-    public function executeInternal()
+    public function execute()
     {
         /** @var \Magento\Framework\Controller\Result\Json $resultJson */
         $resultJson = $this->resultJsonFactory->create();

app/code/Magento/Backend/Controller/Adminhtml/Auth/Login.php

@@ -32,7 +32,7 @@ public function __construct(
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
-    public function executeInternal()
+    public function execute()
     {
         if ($this->_auth->isLoggedIn()) {
             if ($this->_auth->getAuthStorage()->isFirstPageAfterLogin()) {

app/code/Magento/Backend/Controller/Adminhtml/Auth/Logout.php

@@ -13,7 +13,7 @@ class Logout extends \Magento\Backend\Controller\Adminhtml\Auth
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
-    public function executeInternal()
+    public function execute()
     {
         $this->_auth->logout();
         $this->messageManager->addSuccess(__('You have logged out.'));

app/code/Magento/Backend/Controller/Adminhtml/BackendApp/Redirect.php

@@ -39,7 +39,7 @@ public function __construct(
     /**
      * @return \Magento\Framework\Controller\ResultInterface
      */
-    public function executeInternal()
+    public function execute()
     {
         $resultRedirect = $this->resultRedirectFactory->create();
         if ($this->getRequest()->getParam('app')) {

app/code/Magento/Backend/Controller/Adminhtml/Cache/CleanImages.php

@@ -16,7 +16,7 @@ class CleanImages extends \Magento\Backend\Controller\Adminhtml\Cache
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
-    public function executeInternal()
+    public function execute()
     {
         try {
             $this->_objectManager->create('Magento\Catalog\Model\Product\Image')->clearCache();

app/code/Magento/Backend/Controller/Adminhtml/Cache/CleanMedia.php

@@ -16,7 +16,7 @@ class CleanMedia extends \Magento\Backend\Controller\Adminhtml\Cache
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
-    public function executeInternal()
+    public function execute()
     {
         try {
             $this->_objectManager->get('Magento\Framework\View\Asset\MergeService')->cleanMergedJsCss();

app/code/Magento/Backend/Controller/Adminhtml/Cache/CleanStaticFiles.php

@@ -15,7 +15,7 @@ class CleanStaticFiles extends \Magento\Backend\Controller\Adminhtml\Cache
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
-    public function executeInternal()
+    public function execute()
     {
         $this->_objectManager->get('Magento\Framework\App\State\CleanupFiles')->clearMaterializedViewFiles();
         $this->_eventManager->dispatch('clean_static_files_cache_after');

app/code/Magento/Backend/Controller/Adminhtml/Cache/FlushAll.php

@@ -13,7 +13,7 @@ class FlushAll extends \Magento\Backend\Controller\Adminhtml\Cache
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
-    public function executeInternal()
+    public function execute()
     {
         $this->_eventManager->dispatch('adminhtml_cache_flush_all');
         /** @var $cacheFrontend \Magento\Framework\Cache\FrontendInterface */

app/code/Magento/Backend/Controller/Adminhtml/Cache/FlushSystem.php

@@ -13,7 +13,7 @@ class FlushSystem extends \Magento\Backend\Controller\Adminhtml\Cache
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
-    public function executeInternal()
+    public function execute()
     {
         /** @var $cacheFrontend \Magento\Framework\Cache\FrontendInterface */
         foreach ($this->_cacheFrontendPool as $cacheFrontend) {

app/code/Magento/Backend/Controller/Adminhtml/Cache/Index.php

@@ -13,7 +13,7 @@ class Index extends \Magento\Backend\Controller\Adminhtml\Cache
      *
      * @return \Magento\Backend\Model\View\Result\Page
      */
-    public function executeInternal()
+    public function execute()
     {
         /** @var \Magento\Backend\Model\View\Result\Page $resultPage */
         $resultPage = $this->resultPageFactory->create();

app/code/Magento/Backend/Controller/Adminhtml/Cache/MassDisable.php

@@ -16,7 +16,7 @@ class MassDisable extends \Magento\Backend\Controller\Adminhtml\Cache
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
-    public function executeInternal()
+    public function execute()
     {
         try {
             $types = $this->getRequest()->getParam('types');

app/code/Magento/Backend/Controller/Adminhtml/Cache/MassEnable.php

@@ -16,7 +16,7 @@ class MassEnable extends \Magento\Backend\Controller\Adminhtml\Cache
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
-    public function executeInternal()
+    public function execute()
     {
         try {
             $types = $this->getRequest()->getParam('types');

app/code/Magento/Backend/Controller/Adminhtml/Cache/MassRefresh.php

@@ -16,7 +16,7 @@ class MassRefresh extends \Magento\Backend\Controller\Adminhtml\Cache
      *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
-    public function executeInternal()
+    public function execute()
     {
         try {
             $types = $this->getRequest()->getParam('types');