39099: Move constant variable to a new method for extensibility

Author: engcom-Dash

app/code/Magento/PageCache/Model/App/Request/Http/IdentifierForSave.php

@@ -8,6 +8,7 @@
 namespace Magento\PageCache\Model\App\Request\Http;
 
 use Magento\Framework\App\Http\Context;
+use Magento\Framework\App\ObjectManager;
 use Magento\Framework\App\PageCache\Identifier;
 use Magento\Framework\App\PageCache\IdentifierInterface;
 use Magento\Framework\App\Request\Http;
@@ -23,13 +24,17 @@ class IdentifierForSave implements IdentifierInterface
      * @param Context $context
      * @param Json $serializer
      * @param IdentifierStoreReader $identifierStoreReader
+     * @param Identifier|null $identifier
      */
     public function __construct(
         private Http                  $request,
         private Context               $context,
         private Json                  $serializer,
         private IdentifierStoreReader $identifierStoreReader,
+        private ?Identifier $identifier = null
     ) {
+        $this->identifier = $identifier ?: ObjectManager::getInstance()
+            ->get(Identifier::class);
     }
 
     /**
@@ -39,7 +44,7 @@ public function __construct(
      */
     public function getValue()
     {
-        $pattern = Identifier::PATTERN_MARKETING_PARAMETERS;
+        $pattern = $this->identifier->getMarketingParameterPatterns();
         $replace = array_fill(0, count($pattern), '');
         $data = [
             $this->request->isSecure(),

lib/internal/Magento/Framework/App/PageCache/Identifier.php

@@ -13,32 +13,6 @@
  */
 class Identifier implements IdentifierInterface
 {
-    /**
-     * Pattern detect marketing parameters
-     */
-    public const PATTERN_MARKETING_PARAMETERS = [
-        '/&?gad_source\=[^&]+/',
-        '/&?gbraid\=[^&]+/',
-        '/&?wbraid\=[^&]+/',
-        '/&?_gl\=[^&]+/',
-        '/&?dclid\=[^&]+/',
-        '/&?gclsrc\=[^&]+/',
-        '/&?srsltid\=[^&]+/',
-        '/&?msclkid\=[^&]+/',
-        '/&?_kx\=[^&]+/',
-        '/&?gclid\=[^&]+/',
-        '/&?cx\=[^&]+/',
-        '/&?ie\=[^&]+/',
-        '/&?cof\=[^&]+/',
-        '/&?siteurl\=[^&]+/',
-        '/&?zanpid\=[^&]+/',
-        '/&?origin\=[^&]+/',
-        '/&?fbclid\=[^&]+/',
-        '/&?mc_(.*?)\=[^&]+/',
-        '/&?utm_(.*?)\=[^&]+/',
-        '/&?_bta_(.*?)\=[^&]+/',
-    ];
-
     /**
      * @var \Magento\Framework\App\Request\Http
      */
@@ -76,8 +50,8 @@ public function __construct(
      */
     public function getValue()
     {
-        $pattern = self::PATTERN_MARKETING_PARAMETERS;
-        $replace = array_fill(0, count(self::PATTERN_MARKETING_PARAMETERS), '');
+        $pattern = $this->getMarketingParameterPatterns();
+        $replace = array_fill(0, count($pattern), '');
         $data = [
             $this->request->isSecure(),
             preg_replace($pattern, $replace, (string)$this->request->getUriString()),
@@ -87,4 +61,36 @@ public function getValue()
 
         return sha1($this->serializer->serialize($data));
     }
+
+    /**
+     * Pattern detect marketing parameters
+     *
+     *
+     * @return array
+     */
+    public function getMarketingParameterPatterns(): array
+    {
+        return [
+            '/&?gad_source\=[^&]+/',
+            '/&?gbraid\=[^&]+/',
+            '/&?wbraid\=[^&]+/',
+            '/&?_gl\=[^&]+/',
+            '/&?dclid\=[^&]+/',
+            '/&?gclsrc\=[^&]+/',
+            '/&?srsltid\=[^&]+/',
+            '/&?msclkid\=[^&]+/',
+            '/&?_kx\=[^&]+/',
+            '/&?gclid\=[^&]+/',
+            '/&?cx\=[^&]+/',
+            '/&?ie\=[^&]+/',
+            '/&?cof\=[^&]+/',
+            '/&?siteurl\=[^&]+/',
+            '/&?zanpid\=[^&]+/',
+            '/&?origin\=[^&]+/',
+            '/&?fbclid\=[^&]+/',
+            '/&?mc_(.*?)\=[^&]+/',
+            '/&?utm_(.*?)\=[^&]+/',
+            '/&?_bta_(.*?)\=[^&]+/',
+        ];
+    }
 }