GH-26255: Fix logic error around handling both string/array params. Fix failing test case.

Matthew O'Loughlin · Matthew O'Loughlin · commit 4c223031e12b · 2020-01-06T11:58:13.000+10:30
diff --git a/app/code/Magento/CacheInvalidate/Model/PurgeCache.php b/app/code/Magento/CacheInvalidate/Model/PurgeCache.php
@@ -69,7 +69,7 @@ public function __construct(
      */
     public function sendPurgeRequest($tags)
     {
-        if (!is_string($tags)) {
+        if (is_string($tags)) {
             $tags = [$tags];
         }
 
diff --git a/app/code/Magento/CacheInvalidate/Test/Unit/Observer/InvalidateVarnishObserverTest.php b/app/code/Magento/CacheInvalidate/Test/Unit/Observer/InvalidateVarnishObserverTest.php
@@ -54,7 +54,7 @@ protected function setUp()
     public function testInvalidateVarnish()
     {
         $tags = ['cache_1', 'cache_group'];
-        $pattern = '((^|,)cache_1(,|$))|((^|,)cache_group(,|$))';
+        $pattern = ['((^|,)cache_1(,|$))', '((^|,)cache_group(,|$))'];
 
         $this->configMock->expects($this->once())->method('isEnabled')->will($this->returnValue(true));
         $this->configMock->expects(

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function __construct(`
`69`	`69`	`*/`
`70`	`70`	`public function sendPurgeRequest($tags)`
`71`	`71`	`{`
`72`		`- if (!is_string($tags)) {`
	`72`	`+ if (is_string($tags)) {`
`73`	`73`	`$tags = [$tags];`
`74`	`74`	`}`
`75`	`75`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ protected function setUp()`
`54`	`54`	`public function testInvalidateVarnish()`
`55`	`55`	`{`
`56`	`56`	`$tags = ['cache_1', 'cache_group'];`
`57`		`- $pattern = '((^\|,)cache_1(,\|$))\|((^\|,)cache_group(,\|$))';`
	`57`	`+ $pattern = ['((^\|,)cache_1(,\|$))', '((^\|,)cache_group(,\|$))'];`
`58`	`58`
`59`	`59`	`$this->configMock->expects($this->once())->method('isEnabled')->will($this->returnValue(true));`
`60`	`60`	`$this->configMock->expects(`