Skip to content

Commit 48f5a92

Browse files
committed
process code review comments
1 parent 86000ce commit 48f5a92

File tree

4 files changed

+1
-17
lines changed

4 files changed

+1
-17
lines changed

app/code/Magento/Persistent/Test/Unit/Model/QuoteManagerTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,6 @@ public function testSetGuest()
230230
$this->quoteMock->expects($this->once())->method('getItemsQty')->willReturn(1);
231231
$extensionAttributes = $this->getMockBuilder(CartExtensionInterface::class)
232232
->addMethods(['getShippingAssignments', 'setShippingAssignments'])
233-
->disableArgumentCloning()
234233
->getMockForAbstractClass();
235234
$shippingAssignment = $this->createMock(ShippingAssignmentInterface::class);
236235
$extensionAttributes->expects($this->once())

app/code/Magento/Quote/Test/Unit/Model/Quote/Address/Total/SubtotalTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,6 @@ public function testCollect($price, $originalPrice, $itemHasParent, $expectedPri
112112
/** @var Address|MockObject $address */
113113
$address = $this->getMockBuilder(Address::class)
114114
->disableOriginalConstructor()
115-
->disableOriginalClone()
116-
->disableArgumentCloning()
117-
->disallowMockingUnknownTypes()
118115
->onlyMethods(['removeItem', 'getQuote'])
119116
->addMethods(['setTotalQty', 'getTotalQty'])
120117
->getMock();
@@ -167,9 +164,6 @@ public function testCollect($price, $originalPrice, $itemHasParent, $expectedPri
167164

168165
$total = $this->getMockBuilder(Total::class)
169166
->disableOriginalConstructor()
170-
->disableOriginalClone()
171-
->disableArgumentCloning()
172-
->disallowMockingUnknownTypes()
173167
->addMethods(['setVirtualAmount', 'setBaseVirtualAmount'])
174168
->getMock();
175169
$total->expects($this->once())->method('setBaseVirtualAmount')->willReturnSelf();
@@ -194,7 +188,6 @@ public function testFetch()
194188
$quoteMock = $this->createMock(Quote::class);
195189
$totalMock = $this->getMockBuilder(Total::class)
196190
->addMethods(['getSubtotal'])
197-
->disableArgumentCloning()
198191
->getMockForAbstractClass();
199192
$totalMock->expects($this->once())->method('getSubtotal')->willReturn(100);
200193

@@ -241,9 +234,6 @@ public function testCollectWithInvalidItems()
241234
->with($addressItemId);
242235
$addressItem = $this->getMockBuilder(AddressItem::class)
243236
->disableOriginalConstructor()
244-
->disableOriginalClone()
245-
->disableArgumentCloning()
246-
->disallowMockingUnknownTypes()
247237
->onlyMethods(['getId'])
248238
->addMethods(['getQuoteItemId'])
249239
->getMock();

app/code/Magento/Sales/Test/Unit/Model/Order/CreditmemoFactoryTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ protected function setUp(): void
5151
{
5252
$this->orderItemMock = $this->getMockBuilder(Item::class)
5353
->disableOriginalConstructor()
54-
->disableOriginalClone()
55-
->disableArgumentCloning()
56-
->disallowMockingUnknownTypes()
5754
->onlyMethods(['getChildrenItems', 'isDummy', 'getId', 'getParentItemId'])
5855
->addMethods(['getHasChildren'])
5956
->getMock();

lib/internal/Magento/Framework/Pricing/Test/Unit/Adjustment/CollectionTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ function ($code) use ($adjustmentsData) {
7171
/**
7272
* @param string[] $adjustments
7373
* @param string[] $expectedResult
74-
*
7574
* @dataProvider getItemsDataProvider
7675
*/
7776
public function testGetItems($adjustments, $expectedResult)
@@ -92,15 +91,14 @@ public function getItemsDataProvider()
9291
[['adj1'], ['adj1']],
9392
[['adj4'], ['adj4']],
9493
[['adj1', 'adj4'], ['adj1', 'adj4']],
95-
[['adj1', 'adj2', 'adj3', 'adj4'], ['adj3', 'adj1', 'adj2', 'adj4']],
94+
[['adj1', 'adj2', 'adj3', 'adj4'], ['adj3', 'adj1', 'adj2', 'adj4']]
9695
];
9796
}
9897

9998
/**
10099
* @param string[] $adjustments
101100
* @param string $code
102101
* @param $expectedResult
103-
*
104102
* @dataProvider getItemByCodeDataProvider
105103
*/
106104
public function testGetItemByCode($adjustments, $code, $expectedResult)

0 commit comments

Comments
 (0)