string false does not evaluate to false

fooman · fooman · commit 42f53f864115 · 2015-07-22T00:22:37.000+12:00
The false value used here https://github.com/magento/magento2/blob/develop/app/code/Magento/Sales/etc/pdf.xml#L33 gets represented as a string which leads to all totals being shown in the pdfs even if the amount is 0 and it is configured to not show. Checking for the string true fixes it.
diff --git a/app/code/Magento/Sales/Model/Order/Pdf/Total/DefaultTotal.php b/app/code/Magento/Sales/Model/Order/Pdf/Total/DefaultTotal.php
@@ -145,7 +145,7 @@ public function getFullTaxInfo()
     public function canDisplay()
     {
         $amount = $this->getAmount();
-        return $this->getDisplayZero() || $amount != 0;
+        return $this->getDisplayZero() === 'true' || $amount != 0;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ public function getFullTaxInfo()`
`145`	`145`	`public function canDisplay()`
`146`	`146`	`{`
`147`	`147`	`$amount = $this->getAmount();`
`148`		`- return $this->getDisplayZero() \|\| $amount != 0;`
	`148`	`+ return $this->getDisplayZero() === 'true' \|\| $amount != 0;`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`/**`