Skip to content

Commit 42889f8

Browse files
committed
uses magento validation rule
1 parent f5c2575 commit 42889f8

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

app/code/Magento/Checkout/Test/Mftf/Test/StorefrontOnePageCheckoutPhoneValidationTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@
3838
<actionGroup ref="StorefrontOpenCheckoutPageActionGroup" stepKey="guestGoToCheckout"/>
3939

4040
<fillField userInput="Sample text" selector="{{CheckoutShippingSection.telephone}}" stepKey="enterAlphabeticalSymbols"/>
41-
<see userInput="Please enter a valid phone number. For example (123) 456-7890, 123-456-7890, +(123)4567890, +1234567890" selector="{{CheckoutShippingSection.addressFieldValidationError}}" stepKey="checkPhoneFieldValidationIsPassed"/>
41+
<see userInput="Please enter a valid phone number. For example (123) 456-7890 or 123-456-7890." selector="{{CheckoutShippingSection.addressFieldValidationError}}" stepKey="checkPhoneFieldValidationIsPassed"/>
4242
</test>
4343
</tests>

app/code/Magento/Checkout/view/frontend/layout/checkout_index_index.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@
224224
</item>
225225
<item name="telephone" xsi:type="array">
226226
<item name="validation" xsi:type="array">
227-
<item name="validate-phone" xsi:type="number">0</item>
227+
<item name="validate-phoneStrict" xsi:type="number">0</item>
228228
</item>
229229
<item name="config" xsi:type="array">
230230
<item name="tooltip" xsi:type="array">

app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -432,13 +432,6 @@ define([
432432
},
433433
$.mage.__('Please enter a valid phone number. For example (123) 456-7890 or 123-456-7890.')
434434
],
435-
'validate-phone': [
436-
function (value) {
437-
return utils.isEmptyNoTrim(value) ||
438-
/^[+]*[(]{0,1}[0-9]{1,4}[)]{0,1}[-\s\.\/0-9]*$/.test(value);
439-
},
440-
$.mage.__('Please enter a valid phone number. For example (123) 456-7890, 123-456-7890, +(123)4567890, +1234567890')//eslint-disable-line max-len
441-
],
442435
'validate-fax': [
443436
function (value) {
444437
return utils.isEmptyNoTrim(value) || /^(\()?\d{3}(\))?(-|\s)?\d{3}(-|\s)\d{4}$/.test(value);

0 commit comments

Comments
 (0)