Resolve A "500 (Internal Server Error)" appears in Developer Console if Delete the image that is added to Page Content issue25893

Author: edenduong

app/code/Magento/Cms/Controller/Adminhtml/Wysiwyg/Directive.php

@@ -4,6 +4,9 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
+declare(strict_types=1);
+
 namespace Magento\Cms\Controller\Adminhtml\Wysiwyg;
 
 use Magento\Backend\App\Action;
@@ -13,6 +16,8 @@
 
 /**
  * Process template text for wysiwyg editor.
+ *
+ * Class Directive
  */
 class Directive extends Action implements HttpGetActionInterface
 {
@@ -73,10 +78,14 @@ public function execute()
             /** @var Config $config */
             $config = $this->_objectManager->get(Config::class);
             $imagePath = $config->getSkinImagePlaceholderPath();
-            $image->open($imagePath);
-            $resultRaw->setHeader('Content-Type', $image->getMimeType());
-            $resultRaw->setContents($image->getImage());
-            $this->_objectManager->get(\Psr\Log\LoggerInterface::class)->critical($e);
+            try {
+                $image->open($imagePath);
+                $resultRaw->setHeader('Content-Type', $image->getMimeType());
+                $resultRaw->setContents($image->getImage());
+                $this->_objectManager->get(\Psr\Log\LoggerInterface::class)->critical($e);
+            } catch (\Exception $e) {
+                $this->_objectManager->get(\Psr\Log\LoggerInterface::class)->critical($e);
+            }
         }
         return $resultRaw;
     }

app/code/Magento/Cms/Test/Unit/Controller/Adminhtml/Wysiwyg/DirectiveTest.php

@@ -274,4 +274,33 @@ protected function prepareExecuteTest()
             ->method('create')
             ->willReturn($this->imageAdapterMock);
     }
+
+    /**
+     * Test Execute With Deleted Image
+     *
+     * @covers \Magento\Cms\Controller\Adminhtml\Wysiwyg\Directive::execute
+     */
+    public function testExecuteWithDeletedImage()
+    {
+        $exception = new \Exception('epic fail');
+        $placeholderPath = 'pub/static/adminhtml/Magento/backend/en_US/Magento_Cms/images/wysiwyg_skin_image.png';
+        $this->prepareExecuteTest();
+
+        $this->imageAdapterMock->expects($this->at(0))
+            ->method('open')
+            ->with(self::IMAGE_PATH)
+            ->willThrowException($exception);
+        $this->wysiwygConfigMock->expects($this->once())
+            ->method('getSkinImagePlaceholderPath')
+            ->willReturn($placeholderPath);
+        $this->imageAdapterMock->expects($this->at(1))
+            ->method('open')
+            ->willThrowException($exception);
+
+        $this->loggerMock->expects($this->once())
+            ->method('critical')
+            ->with($exception);
+
+        $this->wysiwygDirective->execute();
+    }
 }