Fixing static tests;

bnymn · bnymn · commit 2b2aceed74fc · 2020-09-02T19:23:55.000+02:00
diff --git a/lib/internal/Magento/Framework/Filesystem/Io/File.php b/lib/internal/Magento/Framework/Filesystem/Io/File.php
@@ -440,6 +440,8 @@ public function cd($dir)
      */
     public function read($filename, $dest = null)
     {
+        $result = false;
+        
         $this->_cwd();
         if ($dest === null) {
             $result = @file_get_contents($filename);
diff --git a/lib/internal/Magento/Framework/Filesystem/Test/Unit/Io/FileTest.php b/lib/internal/Magento/Framework/Filesystem/Test/Unit/Io/FileTest.php
@@ -26,7 +26,7 @@ private function getTmpDir()
      */
     public function testReadShouldCopyTheSourceFileToTheGivenFileResource()
     {
-        $content = \mt_rand();
+        $content = \random_int(0, 1000);
         $sourceFileName = "source-file.txt";
         $tmpDir = $this->getTmpDir();
         \file_put_contents("{$tmpDir}/{$sourceFileName}", $content);

Original file line number	Diff line number	Diff line change
`@@ -440,6 +440,8 @@ public function cd($dir)`
`440`	`440`	`*/`
`441`	`441`	`public function read($filename, $dest = null)`
`442`	`442`	`{`
	`443`	`+ $result = false;`
	`444`	`+`
`443`	`445`	`$this->_cwd();`
`444`	`446`	`if ($dest === null) {`
`445`	`447`	`$result = @file_get_contents($filename);`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ private function getTmpDir()`
`26`	`26`	`*/`
`27`	`27`	`public function testReadShouldCopyTheSourceFileToTheGivenFileResource()`
`28`	`28`	`{`
`29`		`- $content = \mt_rand();`
	`29`	`+ $content = \random_int(0, 1000);`
`30`	`30`	`$sourceFileName = "source-file.txt";`
`31`	`31`	`$tmpDir = $this->getTmpDir();`
`32`	`32`	`\file_put_contents("{$tmpDir}/{$sourceFileName}", $content);`