Skip to content

Commit 26dca10

Browse files
committed
Refactor per review comment
1 parent 76a866e commit 26dca10

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

lib/web/mage/adminhtml/browser.js

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ define([
1515
'Magento_Ui/js/modal/modal',
1616
'jquery/ui',
1717
'jquery/jstree/jquery.jstree',
18-
'mage/mage',
18+
'mage/mage'
1919
], function ($, wysiwyg, prompt, confirm, alert, _) {
2020
window.MediabrowserUtility = {
2121
windowId: 'modal_dialog_message',
@@ -53,21 +53,22 @@ define([
5353
content = '<div class="popup-window" id="' + windowId + '"></div>',
5454
self = this;
5555

56-
if (options
57-
&& self.targetElementId
58-
&& self.targetElementId === options.targetElementId
59-
) {
56+
if (options &&
57+
self.targetElementId &&
58+
self.targetElementId === options.targetElementId) {
6059
if (typeof options.closed !== 'undefined') {
6160
this.modal.modal('option', 'closed', options.closed);
6261
}
6362
this.modal.modal('openModal');
6463

6564
return;
66-
} else if (_.isUndefined(options) && self.modalLoaded === true) {
67-
if (self.targetElementId === url) {
68-
this.modal.modal('openModal');
69-
return;
70-
}
65+
} else if (_.isUndefined(options) &&
66+
self.modalLoaded === true &&
67+
self.targetElementId === url
68+
) {
69+
this.modal.modal('openModal');
70+
71+
return;
7172
}
7273

7374
if (this.modal) {
@@ -94,10 +95,11 @@ define([
9495
}).done(function (data) {
9596
self.modal.html(data).trigger('contentUpdated');
9697
self.modalLoaded = true;
97-
self.targetElementId = options
98-
? options.targetElementId
99-
: url;
98+
self.targetElementId = options ?
99+
options.targetElementId
100+
: url;
100101
});
102+
101103
},
102104

103105
/**

0 commit comments

Comments
 (0)