Refactor small line of code. + Code Styling.

Jack Krielen · Jack Krielen · commit 21ad13f6880f · 2020-04-14T08:50:01.000+02:00
diff --git a/app/code/Magento/Tax/Pricing/Render/Adjustment.php b/app/code/Magento/Tax/Pricing/Render/Adjustment.php
@@ -183,8 +183,8 @@ public function displayPriceExcludingTax()
      */
     public function getDataPriceType()
     {
-        if ( $this->getData('price_type') !== 'finalPrice' && $priceType = $this->getData('price_type')){
-            return 'base' . ucfirst($priceType);
+        if ($this->getData('price_type') && $this->getData('price_type') !== 'finalPrice') {
+            return 'base' . ucfirst($this->getData('price_type'));
         }
         return 'basePrice';
     }

Original file line number	Diff line number	Diff line change
`@@ -183,8 +183,8 @@ public function displayPriceExcludingTax()`
`183`	`183`	`*/`
`184`	`184`	`public function getDataPriceType()`
`185`	`185`	`{`
`186`		`- if ( $this->getData('price_type') !== 'finalPrice' && $priceType = $this->getData('price_type')){`
`187`		`- return 'base' . ucfirst($priceType);`
	`186`	`+ if ($this->getData('price_type') && $this->getData('price_type') !== 'finalPrice') {`
	`187`	`+ return 'base' . ucfirst($this->getData('price_type'));`
`188`	`188`	`}`
`189`	`189`	`return 'basePrice';`
`190`	`190`	`}`