Skip to content

Commit 1861380

Browse files
committed
Merge remote-tracking branch 'origin/2.4-develop' into MC-29052
2 parents b2e77cd + ac3eb00 commit 1861380

File tree

3 files changed

+10
-17
lines changed

3 files changed

+10
-17
lines changed

app/code/Magento/DownloadableImportExport/Model/Import/Product/Type/Downloadable.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -365,11 +365,6 @@ protected function isRowValidSample(array $rowData)
365365

366366
$sampleData = $this->prepareSampleData($rowData[static::COL_DOWNLOADABLE_SAMPLES]);
367367

368-
if ($this->sampleGroupTitle($rowData) == '') {
369-
$result = true;
370-
$this->_entityModel->addRowError(self::ERROR_GROUP_TITLE_NOT_FOUND, $this->rowNum);
371-
}
372-
373368
$result = $result ?? $this->isTitle($sampleData);
374369

375370
foreach ($sampleData as $link) {
@@ -406,11 +401,6 @@ protected function isRowValidLink(array $rowData)
406401

407402
$linkData = $this->prepareLinkData($rowData[self::COL_DOWNLOADABLE_LINKS]);
408403

409-
if ($this->linksAdditionalAttributes($rowData, 'group_title', self::DEFAULT_GROUP_TITLE) == '') {
410-
$this->_entityModel->addRowError(self::ERROR_GROUP_TITLE_NOT_FOUND, $this->rowNum);
411-
$result = true;
412-
}
413-
414404
$result = $result ?? $this->isTitle($linkData);
415405

416406
foreach ($linkData as $link) {

dev/tests/integration/testsuite/Magento/Downloadable/_files/product_downloadable_with_link_url_and_sample_url.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@
4444
->setVisibility(Visibility::VISIBILITY_BOTH)
4545
->setStatus(Status::STATUS_ENABLED)
4646
->setLinksPurchasedSeparately(true)
47-
->setLinksTitle('Links')
48-
->setSamplesTitle('Samples')
4947
->setStockData(
5048
[
5149
'qty' => 100,

lib/web/mage/adminhtml/wysiwyg/tiny_mce/plugins/magentowidget/editor_plugin.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,17 +168,22 @@ define([
168168
/(<span class="[^"]*magento-widget[^"]*"[^>]*>)?<img([^>]+id="[^>]+)>(([^>]*)<\/span>)?/i,
169169
function (match) {
170170
var attributes = wysiwyg.parseAttributesString(match[2]),
171-
widgetCode;
171+
widgetCode,
172+
result = match[0];
172173

173174
if (attributes.id) {
174-
widgetCode = Base64.idDecode(attributes.id);
175+
try {
176+
widgetCode = Base64.idDecode(attributes.id);
177+
} catch (e) {
178+
// Ignore and continue.
179+
}
175180

176-
if (widgetCode.indexOf('{{widget') !== -1) {
177-
return widgetCode;
181+
if (widgetCode && widgetCode.indexOf('{{widget') !== -1) {
182+
result = widgetCode;
178183
}
179184
}
180185

181-
return match[0];
186+
return result;
182187
}
183188
);
184189
},

0 commit comments

Comments
 (0)