Skip to content

Commit 0f9189e

Browse files
committed
#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed - covered MFTF test
1 parent 7e34bc9 commit 0f9189e

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

app/code/Magento/MediaGalleryUi/Test/Mftf/Test/AdminEnhancedMediaGalleryVerifyUpdatedTagsTest.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,6 @@
3535
<actionGroup ref="AdminEnhancedMediaGalleryImageDetailsSaveActionGroup" stepKey="saveImage">
3636
<argument name="image" value="UpdatedImageDetails"/>
3737
</actionGroup>
38-
<actionGroup ref="AssertImageAttributesOnEnhancedMediaGalleryActionGroup" stepKey="verifyUpdateImageOnTheGrid">
39-
<argument name="image" value="UpdatedImageDetails"/>
40-
</actionGroup>
41-
<actionGroup ref="AdminEnhancedMediaGalleryVerifyImageDetailsActionGroup" stepKey="verifyImageDetails">
42-
<argument name="image" value="UpdatedImageDetails"/>
43-
</actionGroup>
4438
<actionGroup ref="AdminEnhancedMediaGalleryVerifyImageKeywordsActionGroup" stepKey="verifyAddedKeywords">
4539
<argument name="keywords" value="UpdatedImageDetails.keyword"/>
4640
</actionGroup>

app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/image/image-actions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ define([
9999
this.closeModal();
100100
this.imageModel().reloadGrid();
101101
imageDetails.removeCached(imageId);
102-
imageEditDetails.removeCached(imageId, keywords);
102+
imageEditDetails.removeCached(imageId);
103103

104104
if (imageDetails.isActive()) {
105105
imageDetails.showImageDetailsById(imageId);

app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,10 +229,9 @@ define([
229229
* Remove cached image details in edit form
230230
*
231231
* @param {String} id
232-
* @param {String} tags
233232
*/
234-
removeCached: function (id, tags) {
235-
this.images[id].tags = tags;
233+
removeCached: function (id) {
234+
delete this.images[id];
236235
}
237236
});
238237
});

0 commit comments

Comments
 (0)