Skip to content

Commit 01d907a

Browse files
committed
Fix queue subscribers adding performance
1 parent 4e1a1bc commit 01d907a

File tree

1 file changed

+5
-5
lines changed
  • app/code/Magento/Newsletter/Model/ResourceModel

1 file changed

+5
-5
lines changed

app/code/Magento/Newsletter/Model/ResourceModel/Queue.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,13 @@ public function addSubscribersToQueue(ModelQueue $queue, array $subscriberIds)
8080
$subscriberIds
8181
);
8282

83-
$usedIds = $connection->fetchCol($select);
83+
$usedIds = array_flip($connection->fetchCol($select));
84+
$subscriberIds = array_flip($subscriberIds);
85+
$newIds = array_diff_key($subscriberIds, $usedIds);
86+
8487
$connection->beginTransaction();
8588
try {
86-
foreach ($subscriberIds as $subscriberId) {
87-
if (in_array($subscriberId, $usedIds)) {
88-
continue;
89-
}
89+
foreach ($newIds as $subscriberId) {
9090
$data = [];
9191
$data['queue_id'] = $queue->getId();
9292
$data['subscriber_id'] = $subscriberId;

0 commit comments

Comments
 (0)