Skip to content

Commit abb9b10

Browse files
868: Enhanced error outputting for new Magento 2 Cron Job generation
1 parent 715575e commit abb9b10

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewControllerDialog.form

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@
142142
<grid row="1" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
143143
</constraints>
144144
<properties>
145-
<editable value="true"/>
145+
<editable value="false"/>
146146
<toolTipText value=""/>
147147
</properties>
148148
<clientProperties>
@@ -170,7 +170,7 @@
170170
<grid row="3" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
171171
</constraints>
172172
<properties>
173-
<editable value="true"/>
173+
<editable value="false"/>
174174
<toolTipText value=""/>
175175
</properties>
176176
<clientProperties>

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewCronjobDialog.form

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@
33
<grid id="cbd77" binding="contentPane" layout-manager="GridLayoutManager" row-count="2" column-count="1" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
44
<margin top="10" left="10" bottom="10" right="10"/>
55
<constraints>
6-
<xy x="48" y="54" width="941" height="479"/>
6+
<xy x="48" y="54" width="941" height="504"/>
77
</constraints>
8-
<properties/>
8+
<properties>
9+
<preferredSize width="550" height="350"/>
10+
</properties>
911
<border type="none"/>
1012
<children>
1113
<grid id="94766" layout-manager="GridLayoutManager" row-count="1" column-count="2" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
@@ -49,7 +51,7 @@
4951
</grid>
5052
</children>
5153
</grid>
52-
<grid id="e3588" layout-manager="GridLayoutManager" row-count="12" column-count="3" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
54+
<grid id="e3588" layout-manager="GridLayoutManager" row-count="13" column-count="3" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
5355
<margin top="0" left="0" bottom="0" right="0"/>
5456
<constraints>
5557
<grid row="0" column="0" row-span="1" col-span="1" vsize-policy="3" hsize-policy="3" anchor="0" fill="3" indent="0" use-parent-layout="false"/>
@@ -95,7 +97,7 @@
9597
</component>
9698
<vspacer id="efb9e">
9799
<constraints>
98-
<grid row="11" column="1" row-span="1" col-span="2" vsize-policy="6" hsize-policy="1" anchor="0" fill="2" indent="0" use-parent-layout="false"/>
100+
<grid row="12" column="1" row-span="1" col-span="2" vsize-policy="6" hsize-policy="1" anchor="0" fill="2" indent="0" use-parent-layout="false"/>
99101
</constraints>
100102
</vspacer>
101103
<component id="93bb3" class="javax.swing.JRadioButton" binding="fixedScheduleRadioButton">
@@ -275,6 +277,14 @@
275277
<text value=""/>
276278
</properties>
277279
</component>
280+
<component id="38172" class="javax.swing.JLabel" binding="configPathFieldErrorMessage">
281+
<constraints>
282+
<grid row="11" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
283+
</constraints>
284+
<properties>
285+
<text value=""/>
286+
</properties>
287+
</component>
278288
</children>
279289
</grid>
280290
</children>

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewCronjobDialog.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ public class NewCronjobDialog extends AbstractDialog {
120120
private JLabel cronjobNameFieldErrorMessage;//NOPMD
121121
private JLabel cronGroupComboBoxErrorMessage;//NOPMD
122122
private JLabel cronjobScheduleFieldErrorMessage;//NOPMD
123+
private JLabel configPathFieldErrorMessage;
123124

124125
/**
125126
* Open a new cronjob generation dialog form.

0 commit comments

Comments
 (0)