Skip to content

Commit 134472d

Browse files
967: Code refactoring
1 parent 2cf2f80 commit 134472d

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

src/com/magento/idea/magento2plugin/actions/generation/generator/LayoutXmlTemplateGenerator.java

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import org.jetbrains.annotations.NotNull;
1919

2020
public class LayoutXmlTemplateGenerator extends FileGenerator {
21+
2122
private final LayoutXmlData layoutXmlData;
2223
private final Project project;
2324
private final FindOrCreateLayoutXml findOrCreateLayoutXml;
@@ -42,10 +43,11 @@ public LayoutXmlTemplateGenerator(
4243
* Creates a module layout file.
4344
*
4445
* @param actionName String
46+
*
4547
* @return PsiFile
4648
*/
4749
@Override
48-
public PsiFile generate(final String actionName) {
50+
public PsiFile generate(final @NotNull String actionName) {
4951
final XmlFile layoutXml = (XmlFile) findOrCreateLayoutXml.execute(
5052
actionName,
5153
layoutXmlData.getRoute(),
@@ -54,17 +56,26 @@ public PsiFile generate(final String actionName) {
5456
layoutXmlData.getModuleName(),
5557
layoutXmlData.getArea()
5658
);
59+
60+
if (layoutXml == null) {
61+
return null;
62+
}
5763
final PsiDocumentManager psiDocumentManager =
5864
PsiDocumentManager.getInstance(project);
5965
final Document document = psiDocumentManager.getDocument(layoutXml);
66+
67+
if (document == null) {
68+
return null;
69+
}
6070
WriteCommandAction.runWriteCommandAction(project, () -> {
6171
final XmlTag rootTag = layoutXml.getRootTag();
72+
6273
if (rootTag == null) {
6374
return;
6475
}
65-
6676
psiDocumentManager.commitDocument(document);
6777
});
78+
6879
return layoutXml;
6980
}
7081

0 commit comments

Comments
 (0)