From a070a3273b8ccfc9a798760f61975b4bf3ccde31 Mon Sep 17 00:00:00 2001
From: John S <john00ivy@gmail.com>
Date: Wed, 17 Apr 2019 11:00:10 -0500
Subject: [PATCH 1/2] 
 magento-pangolin/magento2-functional-testing-framework#MQE-1457: [PWA] The
 "waitForPwaElementVisible" action does not reference the 'timeout' value set

- Adding a note regarding the correct variable to set the timeout value.
---
 .../Module/MagentoPwaWebDriver.php                        | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php b/src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php
index 98b13fe90..a0f056edd 100644
--- a/src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php
+++ b/src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php
@@ -17,16 +17,15 @@ class MagentoPwaWebDriver extends MagentoWebDriver
 {
     /**
      * Wait for a PWA Element to NOT be visible using JavaScript.
+     * Add the WAIT_TIMEOUT variable to your .env file for this action.
      *
      * @param null $selector
      * @param null $timeout
      * @throws \Exception
      * @return void
      */
-    public function waitForPwaElementNotVisible($selector, $timeout = null)
+    public function waitForPwaElementNotVisible($selector, $timeout)
     {
-        $timeout = $timeout ?? $this->_getConfig()['pageload_timeout'];
-
         // Determine what type of Selector is used.
         // Then use the correct JavaScript to locate the Element.
         if (\Codeception\Util\Locator::isXPath($selector)) {
@@ -38,6 +37,7 @@ public function waitForPwaElementNotVisible($selector, $timeout = null)
 
     /**
      * Wait for a PWA Element to be visible using JavaScript.
+     * Add the WAIT_TIMEOUT variable to your .env file for this action.
      *
      * @param null $selector
      * @param null $timeout
@@ -46,8 +46,6 @@ public function waitForPwaElementNotVisible($selector, $timeout = null)
      */
     public function waitForPwaElementVisible($selector, $timeout = null)
     {
-        $timeout = $timeout ?? $this->_getConfig()['pageload_timeout'];
-
         // Determine what type of Selector is used.
         // Then use the correct JavaScript to locate the Element.
         if (\Codeception\Util\Locator::isXPath($selector)) {

From 2c847918a4bd8aa140aa6543cd8292a4f734ffd0 Mon Sep 17 00:00:00 2001
From: John S <john00ivy@gmail.com>
Date: Thu, 18 Apr 2019 13:38:20 -0500
Subject: [PATCH 2/2] 
 magento-pangolin/magento2-functional-testing-framework#MQE-1457: [PWA] The
 "waitForPwaElementVisible" action does not reference the 'timeout' value set

- Reverting change.
---
 .../FunctionalTestingFramework/Module/MagentoPwaWebDriver.php   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php b/src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php
index a0f056edd..2c981b244 100644
--- a/src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php
+++ b/src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php
@@ -24,7 +24,7 @@ class MagentoPwaWebDriver extends MagentoWebDriver
      * @throws \Exception
      * @return void
      */
-    public function waitForPwaElementNotVisible($selector, $timeout)
+    public function waitForPwaElementNotVisible($selector, $timeout = null)
     {
         // Determine what type of Selector is used.
         // Then use the correct JavaScript to locate the Element.